Spring scheduled use wrong thread pool when specific scheduler is used.

[jurek7]

I observed that wrong thread pool is used when I specify scheduler via scheduler parameter in @scheduled annotation.

package com.grainger.etl.jobs.config;

import java.util.concurrent.TimeUnit;
import lombok.extern.slf4j.Slf4j;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.scheduling.TaskScheduler;
import org.springframework.scheduling.annotation.Scheduled;
import org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler;

@Configuration
@Slf4j
public class POC {

  @Bean
  public TaskScheduler xxxx() {
    ThreadPoolTaskScheduler threadPoolTaskScheduler = new ThreadPoolTaskScheduler();
    threadPoolTaskScheduler.setPoolSize(1);
    threadPoolTaskScheduler.setThreadNamePrefix("xxxx");
    return threadPoolTaskScheduler;
  }

  @Scheduled(fixedRate = 15, timeUnit = TimeUnit.SECONDS, scheduler = "xxxx")
  public void scheduleX() {
    log.info("Scheduled using xxxx thread pool {}", Thread.currentThread().getName());
  }

  @Bean
  public TaskScheduler yyyy() {
    ThreadPoolTaskScheduler threadPoolTaskScheduler = new ThreadPoolTaskScheduler();
    threadPoolTaskScheduler.setPoolSize(1);
    threadPoolTaskScheduler.setThreadNamePrefix("yyyy");
    return threadPoolTaskScheduler;
  }

  @Scheduled(fixedRate = 15, timeUnit = TimeUnit.SECONDS, scheduler = "yyyy")
  public void scheduleY() {
    log.info("Scheduled using yyyy thread pool {}", Thread.currentThread().getName());
  }
}

Output without datadog agent enabled:

2024-10-23T15:19:21.628+02:00  INFO 123249 --- [          xxxx1] com.grainger.etl.jobs.config.POC         : Scheduled using xxxx thread pool xxxx1
2024-10-23T15:19:21.628+02:00  INFO 123249 --- [          yyyy1] com.grainger.etl.jobs.config.POC         : Scheduled using yyyy thread pool yyyy1

Output with datadog enabled(-javaagent:/home/juri/projects/dd-java-agent.jar):

2024-10-23T15:20:55.253+02:00  INFO 125874 --- [pool-3-thread-1] com.grainger.etl.jobs.config.POC         : Scheduled using xxxx thread pool pool-3-thread-1
2024-10-23T15:20:55.254+02:00  INFO 125874 --- [pool-3-thread-1] com.grainger.etl.jobs.config.POC         : Scheduled using yyyy thread pool pool-3-thread-1

[amarziali]

Hello
thanks for having opened an issue and provided a reproducer and sorry for the late reply.

I gave a try and I have the right thread name with and without the java tracer. I used spring boot 3.3 and the latest java tracer.
Would you mind telling us which spring boot version are you using and which datadog java tracer one?

At same time we do not instrument the spring boot task scheduler directly so we should not interfere in the way the thread it produces are named.

Thanks

[jurek7]

scheduler-issue.zip

and configuration:

Attaching sample project.

[amarziali]

@jurek7 thanks for the reproducer. It looks that recent version of spring scheduling determine the scheduler to be used by calling getQualifier on SchedulingAwareRunnable. Since we wrap that runnable without implementing that interface, that information is lost. Reason why a bad scheduler is used. We're working on a fix

[amarziali]

Fixed on 1.46.0