Skip to content

test(web): update e2e specs for the dForms restyle and for drift already in develop - #209

Closed
josue-commits wants to merge 1 commit into
developfrom
test/e2e-dforms-selectors
Closed

josue-commits wants to merge 1 commit into
developfrom
test/e2e-dforms-selectors

Conversation

@josue-commits

Copy link
Copy Markdown
Contributor

What

Follow-up to the dForms restyle (#208). CI does not run the qa/ Playwright suite, so after the merge I ran the specs that cover the screens the restyle touched, against a production build with the four NEXT_PUBLIC_* vars baked in. 18 tests failed. None was a product bug: all were selectors.

Caused by the restyle

  • The app rail is aside.bg-sidebar, no longer bg-popover (v9-rail-menus, v16-editor-rail-peek).
  • The notification card is data-testid="notification-card" instead of div.p-5 (v2-notifications, v3-form-emails). The testid is the only app change, in notification-settings.tsx.
  • The preview's expand button carries a title, so chips are now counted with button[title^="{{"].

Already stale in develop before the restyle

  • The token catalog has answers, and the respondent card hides the form-link chip (6 and 5 chips).
  • The sample link is the submissions URL.
  • The delete-folder confirmation is an alertdialog, not a dialog (v15-form-folders).
  • Ctrl+K pressed right after goto is lost, because the listener attaches about 350 ms after load. The spec now presses until it takes.
  • The v15 drag works in viewport coordinates. Once the QA database holds many forms, the folder's rows sit far below the fold, so the test uses a tall viewport.

Needs attention

  • Clicking a row's kebab in the second or so after dropping that row into another folder does not open the menu; it recovers on its own and loses no data. I did not compare it against develop, so I do not know whether it predates the restyle. The v15 spec waits for the page to settle before that click.

Test plan

  • v9, v12, v15, v16, v2-branded-dropdown, v2-notifications, v3-form-emails, v3-forms-list, v6-reveal-card, v6-scheduler all pass locally (SQLite, next start, one worker). v12, v2-branded-dropdown, v3-forms-list and v6-* passed in the first run, before the build that added the testid; none of them selects on it
  • pnpm --filter @quill/web typecheck
  • The other qa/ specs (not run)

DCO sign-off on the commit. No changeset: the only app change is a data-testid.

🤖 Generated with Claude Code

…ady in develop

Ran the qa/ specs for the screens the restyle touched (v9, v12, v15, v16,
v2-notifications, v2-branded-dropdown, v3-form-emails, v3-forms-list, v6).
None of the 18 failures was a product bug; all were selectors.

From the restyle:
- the app rail is `aside.bg-sidebar` now, not `bg-popover` (v9, v16)
- the notification card is `data-testid="notification-card"` instead of
  `div.p-5` (v2-notifications, v3-form-emails); the testid is new in
  notification-settings.tsx
- the preview's expand button carries a `title`, so chips are counted with
  `button[title^="{{"]`

Already stale in develop before the restyle:
- the token catalog has `answers`, and the respondent card hides the
  form-link chip (6 and 5 chips)
- the sample link is the submissions URL
- the delete-folder confirmation is an `alertdialog`
- Ctrl+K pressed before hydration is lost, so v15 presses until it takes
- the v15 drag works in viewport coordinates, so it needs a tall viewport
  once the QA database holds many forms, and a pause after a drop before
  the row's menu opens

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Josue Hernandez <josue@daptatech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant