Repository navigation
test(web): update e2e specs for the dForms restyle and for drift already in develop - #209
Closed
josue-commits wants to merge 1 commit into
Closed
josue-commits wants to merge 1 commit into
josue-commits wants to merge 1 commit into
Conversation
…ady in develop
Ran the qa/ specs for the screens the restyle touched (v9, v12, v15, v16,
v2-notifications, v2-branded-dropdown, v3-form-emails, v3-forms-list, v6).
None of the 18 failures was a product bug; all were selectors.
From the restyle:
- the app rail is `aside.bg-sidebar` now, not `bg-popover` (v9, v16)
- the notification card is `data-testid="notification-card"` instead of
`div.p-5` (v2-notifications, v3-form-emails); the testid is new in
notification-settings.tsx
- the preview's expand button carries a `title`, so chips are counted with
`button[title^="{{"]`
Already stale in develop before the restyle:
- the token catalog has `answers`, and the respondent card hides the
form-link chip (6 and 5 chips)
- the sample link is the submissions URL
- the delete-folder confirmation is an `alertdialog`
- Ctrl+K pressed before hydration is lost, so v15 presses until it takes
- the v15 drag works in viewport coordinates, so it needs a tall viewport
once the QA database holds many forms, and a pause after a drop before
the row's menu opens
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Josue Hernandez <josue@daptatech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the dForms restyle (#208). CI does not run the
qa/Playwright suite, so after the merge I ran the specs that cover the screens the restyle touched, against a production build with the fourNEXT_PUBLIC_*vars baked in. 18 tests failed. None was a product bug: all were selectors.Caused by the restyle
aside.bg-sidebar, no longerbg-popover(v9-rail-menus,v16-editor-rail-peek).data-testid="notification-card"instead ofdiv.p-5(v2-notifications,v3-form-emails). The testid is the only app change, innotification-settings.tsx.title, so chips are now counted withbutton[title^="{{"].Already stale in develop before the restyle
answers, and the respondent card hides the form-link chip (6 and 5 chips).alertdialog, not adialog(v15-form-folders).gotois lost, because the listener attaches about 350 ms after load. The spec now presses until it takes.Needs attention
Test plan
v9,v12,v15,v16,v2-branded-dropdown,v2-notifications,v3-form-emails,v3-forms-list,v6-reveal-card,v6-schedulerall pass locally (SQLite,next start, one worker).v12,v2-branded-dropdown,v3-forms-listandv6-*passed in the first run, before the build that added the testid; none of them selects on itpnpm --filter @quill/web typecheckqa/specs (not run)DCO sign-off on the commit. No changeset: the only app change is a
data-testid.🤖 Generated with Claude Code