Repository navigation
Conversation
The contract cards on device, module, and virtual machine pages only show the contract ID and SKU, so the coverage window — the first thing anyone asks about a support contract — requires opening each contract. This exposes it in place: - add a 'start' column (contract__start) to SupportContractAssignmentTable; the effective 'end' column (assignment-level override falling back to the contract's end) already exists but was hidden from the cards - include 'start' and 'end' in the contract card's include_columns and stop excluding 'end' there; 'renewal' intentionally stays hidden
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The contract cards on the device, module, and virtual machine detail pages currently show only the contract ID and SKU. This exposes the coverage window in the same card:
startcolumn onSupportContractAssignmentTable(contract__start)endcolumn (the assignment-level end override falling back to the contract's end, via the existingend_dateproperty); the card was simply excluding itSo
ContractMixin'sinclude_columnsbecomes['contract', 'sku', 'start', 'end']andendleavesexclude_columns.renewalintentionally stays hidden — it's administrative rather than part of the coverage window, and the card should stay compact.Why
The coverage window is the first thing anyone asks about a support contract. Today it requires clicking through to each contract from the card, even though the data (and the table columns for it) are already right there — the card just filters them out.
Notes
start – endcolumn).