Skip to content

Show start and end dates on the device/module/VM contract cards - #174

Open
dr4gon123 wants to merge 1 commit into
DanSheps:mainfrom
dr4gon123:contract-card-dates
Open

dr4gon123 wants to merge 1 commit into
DanSheps:mainfrom
dr4gon123:contract-card-dates

Conversation

@dr4gon123

Copy link
Copy Markdown

What

The contract cards on the device, module, and virtual machine detail pages currently show only the contract ID and SKU. This exposes the coverage window in the same card:

  • Start Date — new start column on SupportContractAssignmentTable (contract__start)
  • End Date — the table already had an end column (the assignment-level end override falling back to the contract's end, via the existing end_date property); the card was simply excluding it

So ContractMixin's include_columns becomes ['contract', 'sku', 'start', 'end'] and end leaves exclude_columns. renewal intentionally stays hidden — it's administrative rather than part of the coverage window, and the card should stay compact.

Why

The coverage window is the first thing anyone asks about a support contract. Today it requires clicking through to each contract from the card, even though the data (and the table columns for it) are already right there — the card just filters them out.

Notes

  • No migrations; two files plus the table registration, ~8 lines.
  • Tabbed active/expired/future/unspecified behavior is unchanged.
  • Happy to adjust column order/labels if you'd prefer a different presentation (e.g. a single combined start – end column).

The contract cards on device, module, and virtual machine pages only
show the contract ID and SKU, so the coverage window — the first thing
anyone asks about a support contract — requires opening each contract.

This exposes it in place:

- add a 'start' column (contract__start) to
  SupportContractAssignmentTable; the effective 'end' column
  (assignment-level override falling back to the contract's end)
  already exists but was hidden from the cards
- include 'start' and 'end' in the contract card's include_columns and
  stop excluding 'end' there; 'renewal' intentionally stays hidden

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant