Repository navigation
feat: add workspace port inventory support - #127
Conversation
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nical Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
…nical Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
…nical Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
## Summary Sync the vendored Deep Work Plan skill pack from v6.0.1 to v6.0.2 and re-stamp the harness provenance. ## Change Log - Reinstalled .agents/skills/deepworkplan at v6.0.2 (installed tree was byte-identical to v6.0.1 beforehand, so no local adaptations were lost) - Updated skills-lock.json hash, AGENTS.md DWP standard stamp and the skills catalog version line - Addons already current: AI Diff Reviewer v3.2.2, Dailybot skill 3.23.2 ## Risks - None for CLI users; agent tooling only. .dwp/ plans untouched. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Brings the launcher and scripts/workspace_ports_display.py to the hub's e893c0c state (herdr-layout tab dedupe, null ports render as dash), so a fresh dbdev workspace checkout no longer shows dev.sh as modified. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Picks up the herdr-layout keep-mode hardening, scoped ports listing and the ports helper's '-' rendering for empty ports in container mode. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
AI review for
|
There was a problem hiding this comment.
Code review — 0 finding(s): 0 critical · 0 warning · 0 info
Verification: 0 verified · 0 downgraded · 0 refuted · 0 unverified · 0 skipped — grok-4.5
Check: ✅ passing — strictness block-on-critical: highest severity warning ≤ critical threshold
No findings posted inline.
Summary
No code changed since ea118266, so this round spent no review turns and re-read the 6 outstanding finding(s) with the verifier instead:
scripts/workspace_ports_display.py:1521 (warning) — verified: AGENTS.md Rule 2 requires type hints on all parameters;_render_urlsat line 152 takes untypedrecords, and the same new file also leavesread_jsonas baredictplus untypedto_int/showpascripts/workspace_ports_display.py:1412 (warning) — verified: Anchor line 141 embeds sock.settimeout(0.2) as a bare literal, and AGENTS.md Rule 12 explicitly requires extracting timeouts/limits into module-level constants. The defect matches the documented rulescripts/workspace_ports_display.py:913 (warning) — verified: AGENTS.md Rule 6 requires a failing*_test.pybefore new behavior;scripts/workspace_ports_display.pyis a new file whoserender_containerencodes non-trivial contracts (4-part port splitting, Ddev.sh:8534 (warning) — unverified: verifier ended without a verdict within 4 turnsscripts/workspace_ports_display.py:205 (warning) — verified:to_intat scripts/workspace_ports_display.py:20 is defined asdef to_int(value, default: int = 0) -> int, sovaluelacks a type hint while other annotations are present. AGENTS.md Rule 2 requirescripts/workspace_ports_display.py:276 (warning) — verified: AGENTS.md Rule 2 requires type hints on all parameters;showat line 27 annotates only the return type (-> str) and leavesvaluebare, same as nearbyto_int/_render_urls.
Prior findings
- still open
scripts/workspace_ports_display.py:152 - still open
scripts/workspace_ports_display.py:141 - still open
scripts/workspace_ports_display.py:91 - still open
dev.sh:853 - still open
scripts/workspace_ports_display.py:20 - still open
scripts/workspace_ports_display.py:27
Check status: ✅ passing — strictness
block-on-critical, highest severity in effectwarning: highest severitywarning≤ critical threshold.This line is written by the reviewer runtime after the gate ran and matches the check conclusion and the tracking comment. Any recommendation above is the model's advisory opinion, not the gate.
Footnotes
-
scripts/workspace_ports_display.py:152is mentioned above but is not a row of the findings table (not posted inline). ↩ -
scripts/workspace_ports_display.py:141is mentioned above but is not a row of the findings table (not posted inline). ↩ -
scripts/workspace_ports_display.py:91is mentioned above but is not a row of the findings table (not posted inline). ↩ -
dev.sh:853is mentioned above but is not a row of the findings table (not posted inline). ↩ -
scripts/workspace_ports_display.py:20is mentioned above but is not a row of the findings table (not posted inline). ↩ -
scripts/workspace_ports_display.py:27is mentioned above but is not a row of the findings table (not posted inline). ↩
Summary
Adds reusable workspace service-port allocation and direct access while preserving Caddy focus routing.
Validation
Scope
Dynamic service ports, workspace port inventory commands, stable satellite exposure, focus proxy updates, and onboarding/Herdr documentation where applicable.