Fix missing transcript resets - #3776
Draft
LeonLinAtAMI wants to merge 1 commit into
Draft
Conversation
…paths (DMTF#3726) Signed-off-by: Leon Lin (林彥廷) <leonlin@ami.com> Assisted-by: GitHub Copilot CLI:claude-sonnet-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3726 on cases of B.2 and B.3.
About B.1 (message_b not reset on GET_CERTIFICATE)
As issue #3726 literally suggests, would break legitimate multi-portion/multi-slot retrieval.
A correct fix requires distinguishing "retry of a failed request" from "next portion/slot request," which needs additional state (e.g., comparing against last_spdm_request ) not present in the current codebase.
Please let me know if any suggestion.