Skip to content

Lookup per invalid IP address gives Internal Server Error #9

Description

@btlogy

Likely introduced by #1, query sent with invalid or empty IP gives a 500:

$ curl -vvv 'https://bgpranking.circl.lu/ipasn' -d 'ip='
...
> POST /ipasn HTTP/1.1
> Host: bgpranking.circl.lu
> User-Agent: curl/x.x.x
> Accept: */*
> Content-Length: 3
> Content-Type: application/x-www-form-urlencoded
> 
* upload completely sent off: 3 out of 3 bytes
< HTTP/1.1 500 INTERNAL SERVER ERROR
< Date: Wed, 29 May 2019 18:30:38 GMT
< Server: gunicorn/x.x.x
< Strict-Transport-Security: max-age=15768000
< Content-Type: text/html
< Content-Length: 290
< Connection: close
< 
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>500 Internal Server Error</title>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application.</p>
...

Activity

  1. btlogy commented on May 29, 2019

    @btlogy
    Author

    I guess it lacks a validation here

  2. Rafiot commented on May 29, 2019

    @Rafiot
    Contributor
  3. adulau commented on May 29, 2019

    @adulau
    Member

    Indeed, if the value is not an IP (any string), you'll get back a 500.

  4. Rafiot commented on May 29, 2019

    @Rafiot
    Contributor

    (.... and moving it back to here because the webserver doesn't return anything anymore and I don't have time to fix it rn)

  5. reopened this on May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions