Repository navigation
Feature - Add Version To Composite Action and Reusable Workflow - #110
Closed
oreenlivnicode wants to merge 6 commits into
Closed
oreenlivnicode wants to merge 6 commits into
oreenlivnicode wants to merge 6 commits into
Conversation
oreenlivnicode
marked this pull request as draft
October 30, 2023 17:07
oreenlivnicode
marked this pull request as ready for review
October 30, 2023 17:11
oreenlivnicode
changed the title
oreenlivnicode
force-pushed
the
feature-add-version-to-composite-action
branch
from
October 31, 2023 09:18
76f5405 to
7959f01
Compare
alex-ilgayev
suggested changes
Oct 31, 2023
alex-ilgayev
left a comment
alex-ilgayev
left a comment
Contributor
There was a problem hiding this comment.
After review most of it,
I think we need to smartly change the dependency.py to have something like:
from_uses_string(), and to_uses_string()
and avoid any parsing of the string (even with split("@")) outside that class.
Means - we get the uses string, parse it to understand the tag, and do all the download and analysis according to that.
When we want to save/identify that action, we can use that to_uses_string() to have unique identification for it, for various reasons:
- save it in db
- help the graph relations
- etc
oreenlivnicode
marked this pull request as draft
October 31, 2023 13:12
oreenlivnicode
force-pushed
the
feature-add-version-to-composite-action
branch
from
October 31, 2023 16:10
78ce624 to
291736b
Compare
elad-pticha
reviewed
Oct 31, 2023
elad-pticha
left a comment
elad-pticha
left a comment
Contributor
There was a problem hiding this comment.
Can you add a test about this in the integration test also?
oreenlivnicode
force-pushed
the
feature-add-version-to-composite-action
branch
from
November 1, 2023 11:47
291736b to
98c69da
Compare
Contributor
|
@oreenlivnicode Make sure to rebase and change |
Might have bugs.
If tag is found we will get download_url from tag object returned by API call. Else, we will get download_url from main contents page in the repo (also by API).
Support tags in reusable workflows (Workflow)
oreenlivnicode
force-pushed
the
feature-add-version-to-composite-action
branch
from
November 7, 2023 12:54
98c69da to
107564c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.