Skip to content

Validate if symlink edgecase still exist when indexing  #63

Open

Description

@oreenlivnicode
if isinstance(obj, str):
                # TODO: This is a symlink. We should handle it.
                # Only examples at the moment are for https://github.com/edgedb/edgedb-pkg
                # E.g. https://github.com/edgedb/edgedb-pkg/blob/master/integration/linux/build/centos-8/action.yml
                logger.debug(f"[-] Symlink detected: {content}. Skipping...")
                return

This code block appears twice in indexer.py.
We should validate if this bug still exists, and if so, fix it.

Activity

  1. alex-ilgayev commented on Nov 5, 2023

    @alex-ilgayev
    Contributor

    Even though the checks are in the indexer, the fix should be in the downloader (so I labeled accordingly).
    I believe the bug still exists, as we did nothing in the downloader to handle symlinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions