Repository navigation
Skip empty ingredients in crafting plans of running jobs - #237
Open
rubensworks wants to merge 1 commit into
Open
rubensworks wants to merge 1 commit into
rubensworks wants to merge 1 commit into
Conversation
Integrated Crafting keeps an empty instance in the buffer of a crafting job when ingredients are added to it, so that the next insertion has a free slot. These were shown as empty stored ingredients in running crafting plans: an empty cell in the compact view and empty rows in the tree list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C5iUzweRYoCkKB5bvJdH8Y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #236 to 1.20.
When ingredients are added to the buffer of a crafting job, Integrated Crafting's
CraftingJob#addToIngredientsStorageBufferadds an empty instance to the buffer first, so that the insertion always has a free slot, and that empty instance stays in the buffer.IntegratedCraftingHelpers#getPrototypesFromIngredientsturned it into an ingredient, so running crafting plans showed empty stored ingredients. It now skips empty instances.Tested with
./gradlew buildon JDK 17. The game test from #236 is not included, as this branch has no game tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01C5iUzweRYoCkKB5bvJdH8Y
Generated by Claude Code