Repository navigation
Don't let a long disk label overlap the disk selector - #84
Merged
Merged
Conversation
In some languages, such as Brazilian Portuguese ("Disco:"), the disk label
was drawn under the disk selector arrow. It is now cut off with an ellipsis
when it does not fit.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
Coverage Report for CI Build 39110034766Coverage decreased (-0.09%) to 47.267%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions107 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
Cutting "Disco:" off left only "Di…", which is hard to read. The label is now scaled to the space before the disk selector, so it is always shown in full. The English label fits that space exactly, so it keeps its normal size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent of the terminal UX stack, based on
master-1.21-lts.In Brazilian Portuguese, the disk label "Disco:" in the scripting terminal was drawn under the left arrow of the disk selector.
The label is now scaled (with CyclopsCore's
RenderHelpers.drawScaledString) to the 21px before the disk selector, and vertically centered. The translations are unchanged. The English "Disk:" is exactly 21px wide, so it stays at its normal size.The first commit cut the label off with "…" instead, but in pt_br that left only "Di…". The second commit replaces it with the scaling.
Checked in-game
Only en_us, pt_br and zh_cn ship this key. The German and Russian strings were only added locally to test a long and a short label.
./gradlew buildand./gradlew runGameTestServer(22 tests) pass.🤖 Generated with Claude Code
https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9