Repository navigation
XSI_TYPE in vocabs not serialized due to logical error #313
Description
https://github.com/CybOXProject/python-cybox/blob/master/cybox/common/vocabs.py#L123
Note the right-hand side of the OR expression will return True if an XSI_TYPE and xsi_type is set making self.is_plain() return True which is False...
Activity
Fix VocabString.is_plain(). closes CybOXProject#313
emmanvg commentedon Feb 26, 2018
It affects
to_dict()because it makes use of it, but it can also affect the general code logic when used outside.gtback commentedon Feb 27, 2018
Can we add a test that demonstrates this? I remember why we made
is_plain(), but I don't really understand the implications of this change.