Repository navigation
fix(auth): show Privacy/ToS footer links on login too, point at madevisible.io - #5
Merged
Merged
Conversation
…isible.io TikTok's App Review rejected the connected app "madevisible.io Social" on 04.09.2026: the site had no visible Privacy Policy/Terms of Service links at all, without opening a menu or logging in. Live-verified via Playwright with a fresh, cookie-cleared session: the login page shows only a "Forgot password?" link, nothing else. Root cause: the only legal footer (auth.legal translation) was gated behind v-if="!isSelfHosted" in Register.vue, and Login.vue never had it. This deployment runs trypost.self_hosted=true (single-operator model, not multi-tenant SaaS like trypost.it itself), so the footer was unconditionally hidden on both pages that matter for App Review. - lang/*/auth.php (all 16 locales): auth.legal's hardcoded https://trypost.it/terms and /privacy URLs -> https://madevisible.io/agb/ and /privacy/ (both now name "madevisible.io Social" explicitly, see Cryptoom/digital-mind-agency#396). - Register.vue: dropped the isSelfHosted guard, footer always shows. - Login.vue: added the same footer block (didn't exist before). See PATCHES.md Patch 4 for the full merge-safety marker strings. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Round-2 review flagged that lang/*/auth.php only take effect after a real `docker compose up -d --build`: laravel-vue-i18n compiles the PHP locale files to gitignored lang/php_*.json at build time, so a plain file-copy-and-restart on web02 would silently keep serving the old trypost.it URLs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
madevisible.io Socialon 04.09.2026, third point: "Valid Privacy Policy and Terms of Service links must be clearly visible on the website URL without needing to open a menu or log in, and both links must be active." Live-verified with Playwright (fresh, cookie-cleared session, confirmed "Log in - TryPost" i.e. real logged-out state): the login page had zero legal links, only "Forgot password?".auth.legali18n key) was rendered only inRegister.vue, gated behindv-if="!isSelfHosted". This deployment runstrypost.self_hosted=true, so the footer was unconditionally hidden.Login.vuenever had the block at all.Register.vue(always shows now), added the same footer block toLogin.vue, and repointed the hardcodedtrypost.it/terms/trypost.it/privacyURLs in all 16 locale files tohttps://madevisible.io/agb/andhttps://madevisible.io/privacy/(both now name "madevisible.io Social" by name, see Cryptoom/digital-mind-agency#396).PATCHES.mdwith merge-safety marker strings, following the existing pattern from Patches 1-3.Test plan
php -lon all 16 modifiedlang/*/auth.phpfilesLogin.vue/Register.vue(div open/close counts match)check-dashes.shclean (2 pre-existing em-dashes in untouched upstream copy elsewhere in the same files, confirmed via diff that they are NOT part of this change)node_modules), verification happens via the realdocker compose up -d --buildrebuild on web02 after mergesocial.madevisible.io/loginand/registershow the footer with working links tomadevisible.io/agb/and/privacy/, logged out, no menu needed🤖 Generated with Claude Code