Repository navigation
feat(mcp): add update-workspace-tool for brand settings - #1
Merged
Merged
Conversation
GetWorkspaceTool is read-only; there was no API or MCP path to write a workspace's brand settings (name, colors, voice traits, font, image style, content language). Adds UpdateWorkspaceTool mirroring UpdateWorkspaceRequest's validation with PATCH semantics (only passed fields change), gated on the same 'update' ability as the settings UI. Registered as fork Patch 1 in PATCHES.md.
UpdateWorkspaceTool validated brand_voice_traits against the enum but never ran BrandVoiceTrait::coerce(), so an update could store an incoherent set (e.g. both formal and casual). This is the first programmatic/unattended MCP write path, so coerce it here before the values land in the update payload. Also rename a test whose name implied a cross-workspace injection vector that the tool schema does not expose. The tool always resolves the caller's current workspace; there is no workspace_id parameter to attack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
No changes to UpdateWorkspaceRequest, WorkspacePolicy, or any other existing tool/validation logic.