HS-1141567 ensure accountlist is selected before navigating to settings pages - #925
Merged
dr-bizz merged 3 commits intoApr 25, 2024
Conversation
…ven't yet selected a accountListId
Contributor
Bundle sizes [mpdx-react]Compared against f61cf8c No significant changes found |
canac
approved these changes
Apr 24, 2024
| <SearchMenu /> | ||
| <AddMenu /> | ||
| <NotificationMenu /> | ||
| {accountListId && ( |
Contributor
There was a problem hiding this comment.
Thanks for fixing this! I'd noticed that trying to create a task if you don't have an account list selected would cause errors, but I never got around to fixing it.
dr-bizz
added
the
On Staging
dr-bizz
deleted the
hs-1141567-ensure-accoutnList-selected-before-navigating-to-settings-pages
branch
April 25, 2024 12:46
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for #1 from this Helpscout ticket.
Users can no longer access the top bar links that require an accountList to be present.
Checklist: