MPDX-8832 Stop over-writing custom task name when action changes

[tamvu-cru]

Description

https://jira.cru.org/browse/MPDX-8832

The task name keeps being overwritten whenever the task type and action fields are selected. Now it will not overwrite what the user typed in the task name field; it only autofills when the task name is empty or has other generic autofilled content.

Testing

MPDX -> Tasks -> Add Task -> Select Task Type -> Select Action (Task name should now autofill):
1. Rewrite the Task Name to whatever you want-> Change the Action or the Task Type -> Task Name should not change
2. Delete the Task Name -> Change the Action or the Task Type -> Task Name should autofill again.

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels (Add the label "Preview" to automatically create a preview environment)
• I have run the Claude Code /quality:agent-review command locally and fixed any relevant suggestions
• I have requested a review from another person on the project
• I have tested my changes in preview or in staging
• I have cleaned up my commit history

[github-actions]

Bundle sizes [mpdx-react]

Compared against 4a196e3

No significant changes found

[zweatshirt]

Can we change this currentSubject to currentTaskName? What do you think?

[tamvu-cru]

yes

[github-actions]

Preview branch generated at https://MPDX-8832-stop-over-writing-custom-task-name-when-action-changes.d3dytjb8adxkk5.amplifyapp.com

[tamvu-cru]

🤖 agent-review · ✅ no blockers · risk MEDIUM
Rollout: shadow — this report cannot approve or block the PR (advisory only). · 4 agents run (Architecture Review Agent, Testing & Quality Review Agent, Standards Compliance Review Agent, UX Review Agent) · 1 debate round run

BLOCKERS — fix or dismiss to pass

✅ No blockers.

OTHER FINDINGS (3)

• #1 · 5/10 · src/components/Task/Modal/Form/TaskModalForm.test.tsx:132 — Only the Action dropdown has a test proving a custom task name survives a change; the same currentTaskName plumbing was also added to the Task Type onChange handler, but no test covers it (testing)
• #2 · 4/10 · src/components/Task/Modal/Form/TaskModalHelper.ts:236 — The custom-name-preservation branch in setTaskName (and its callers) has zero direct unit tests in TaskModalHelper.test.ts; only exercised indirectly through full form renders (testing)
• #3 · 3/10 · src/components/Task/Modal/Form/TaskModalForm.mock.tsx:1 — This diff removed the only imports of createTasksMutationMock/updateTaskMutationMock/deleteTaskMutationMock, leaving the whole mock file dead code (standards)

🔧 Fix suggestions (1)

#3 — Delete dead mock file: src/components/Task/Modal/Form/TaskModalForm.mock.tsx:1

- (entire file, no longer referenced anywhere in src/)
+ git rm src/components/Task/Modal/Form/TaskModalForm.mock.tsx

Apply: bash /tmp/automated_fixes/fix_1_dead_file.sh (or bash /tmp/automated_fixes/apply_all.sh for a dry run first)

📦 Dependency impact

Blast radius: 6 transitive dependents (index enabled, warmed this session).

Direct dependents of changed files:

• TaskModalHelper.ts → TaskModalCompleteForm.tsx, ResultAutocomplete.test.tsx, ResultAutocomplete.tsx, TaskModalHelper.test.ts (4 dependents — highest impact)
• TaskModalLogForm.tsx → TaskModalLogForm.test.tsx (1 dependent)
• TaskModalForm.tsx, TaskModalForm.test.tsx — no dependents

No breaking changes detected (no exports removed; currentTaskName/previousActivityType are additive parameters).

📊 Review detail & stats

Generated: 2026-09-01 · Day: Tuesday · Files changed: 4 (+146 -77 lines)
Risk score: 6/10+ — MEDIUM · Required reviewer: entry-level+

Risk factors detected: pattern score 4 (medium-tier src/components/**/*.{ts,tsx}) + volume score 2; no special patterns; no unmatched paths

Deterministic evidence:

• AST/static rules: none (ast_grep disabled in config)
• CI snapshot: unavailable (no evidence artifact supplied for this local run)
• Cross-repo context: none

Agent summary (bands: Critical 9-10 · High 7-8 · Important 5-6 · Suggestions 3-4):

Agent	Critical	High	Important	Suggestions	Confidence
Architecture Review Agent	0	0	0	0	High
Testing & Quality Review Agent	0	0	2	1	Medium
Standards Compliance Review Agent	0	0	0	1	High
UX Review Agent	0	0	0	0	High
Total	0	0	2	2	-

Per-agent perspectives on blockers: No blockers to detail.

Debate summary:

• Rounds: 1 · Challenges raised: 0 (defended 0, conceded 0) · Findings revised: 0 · Severity adjustment: 0 average · Escalated to human: 0
• No formal challenges. Architecture strongly supported the standards dead-file finding (independently re-verified via grep) and suggested it could reasonably run 3→5 for drift risk; standards and UX both suggested testing's finding Tasks #1 (Task Type/Phase test gap) could run higher (6-7) given it's an unverified path in a bug-fix PR. None of these crossed the severity-7 blocker threshold, so consensus severities were left as each owning agent originally rated them — see the findings above for the as-rated scores.

Review quality:

• Average agent confidence: High · Consensus rate: ~33% (1 of 3 final findings corroborated by a merge of 2 raw findings) · Review time: ~4 minutes
• Findings suppressed by approved learnings: 0

💬 How to act on this review

Every finding above is numbered. No severity ≥7 findings exist, so nothing blocks this PR — all three are advisory. Locally: /agent-review:address pulls this ledger into a Claude Code session. (This repo is in shadow rollout mode, so @claude fix/dismiss PR-comment interaction isn't wired to auto-approve yet.)

• #3 has an available automated fix (bash /tmp/automated_fixes/apply_all.sh to dry-run, --yes to apply)
• #1 and #2 are test-coverage gaps — the fix field on each finding gives a concrete starting point

[github-actions]

Preview branch generated at https://MPDX-8832-stop-over-writing-custom-task-name-when-action-changes.d3dytjb8adxkk5.amplifyapp.com

[zweatshirt]

Don't forget to put the ticket link in the description
Also, as we go, we should update ticket statuses. Since this PR is ready for review we can move it to 'Ready for Review' on the MPDX Jira board

[zweatshirt]

Thanks for working on this Tam