Repository navigation
fix(mobile): Android connection switches toggle on the first tap - #100
Open
CreatorGhost wants to merge 1 commit into
Open
CreatorGhost wants to merge 1 commit into
CreatorGhost wants to merge 1 commit into
Conversation
The environment switch sat inside the row's Pressable. On Android, once the Pressable becomes the JS responder its native view intercepts move events, so the Compose switch got cancelled and the tap opened details instead. The switch now sits beside the row's Pressable. Same fix for the Add Project GitHub switch.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:trusted
Contributor
Thread transfer impact
This comment will update automatically after the next completed run. |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, the environment on/off switch needed several taps. It sat inside the row's Pressable; once that Pressable becomes the JS responder, its native view intercepts the finger's move events, so the Compose switch gets ACTION_CANCEL and the tap opens details instead.
The switch now sits beside the row's Pressable (label area and chevron still open details / expand). The Add Project "Create private repository on GitHub" switch had the same nesting and gets the same fix.
Tested on the Android emulator with real-finger taps (small swipe): before, 0/10 taps toggled; after, 20/20 on the list and 12/12 on the details screen, with no accidental navigation.