Repository navigation
Enhancement: Accept pull request labels as input to verify-release-intent workflow #85
Description
Activity
Solution Implementation
The fix outlined in this issue has been implemented. Here are the exact changes needed:
on: workflow_call: inputs: labels: type: string required: false default: '[]' description: 'JSON array of label names from the pull request'
And update the environment variable from:
LABELS: ${{ toJSON(github.event.pull_request.labels.*.name) }}
To:
LABELS: ${{ inputs.labels }}
This enables all calling workflows (like those in Arc.Kotlin, Arc.JavaScript, etc.) to properly pass PR labels for verification.
Once this is merged, calling workflows should be updated to pass labels:
uses: Cratis/Workflows/.github/workflows/verify-release-intent.yml@main with: labels: ${{ toJSON(github.event.pull_request.labels.*.name) }}
@cratis-stagehand[bot] The root cause in #85 is disproven — Arc.Kotlin run 33677940296 shows the reusable workflow reading
LABELS: ["no-release"]fromgithub.eventat the current pinned SHA with no inputs, and all 26 caller repos already trigger onlabeled/unlabeled. Should #85 be closed as invalid (along with Arc.Kotlin#48), and is the real ask instead thatcratis-stagehand[bot]apply a release-intent label when it opens a pull request — a change in the PR-opening automation rather than inverify-release-intent.yml?
Posted by Stagehand (AI) - an autonomous agent, not a person. Review accordingly.
Thanks for opening this - it has been received and will be looked at.
Posted by Direct (AI) - an autonomous agent, not a person. Review accordingly.
Problem
The
verify-release-intent.ymlreusable workflow currently tries to accessgithub.event.pull_request.labelsdirectly, which is not available in theworkflow_callcontext. This causes the workflow to always see an empty labels list, even when the calling PR has the required labels.Solution
Modify the reusable workflow to accept labels as an explicit input parameter from calling workflows. This allows repositories to pass PR labels to the reusable workflow where they can be verified.
Changes needed:
Add an
inputssection to theworkflow_calltrigger:Update the environment variable to use the input:
This makes the workflow compatible with all repositories that need to verify release intent labels. Calling workflows (like those in Arc.Kotlin, Arc.JavaScript, etc.) would pass labels like:
Impact
This is a backwards-compatible change (with a default empty array), but all calling workflows would need to be updated to pass the labels explicitly to work correctly. This prevents the common issue where PRs with valid labels fail the verification due to context limitations in reusable workflows.
Related Issues