Fix the JavaScript Build failures on the query-states branch - #340
Open
cratis-direct[bot] wants to merge 2 commits into
Open
cratis-direct[bot] wants to merge 2 commits into
cratis-direct[bot] wants to merge 2 commits into
Conversation
added 2 commits
September 26, 2026 07:20
The public API TSDoc gate (verify-api-docs) flags the four members the query-state work introduced: every declaration reachable from a JS exports subpath must carry a TSDoc comment. Describe what each state renders so the enum documents itself the way NumberInputCommitReason does.
The query-state rows and the PivotViewer loading label pushed the published aggregate stylesheet to 32791 gzip bytes, 23 past the reviewed 32 KiB ceiling that every renderer-adapter, package-manager and arc-consumer leg re-checks. The ceiling is deliberately never raised without a compensating reduction, so take one: the per-file separator comment that ships inside the aggregate and every per-area stylesheet loses its dash run. Measured on the packed archive: raw 203689, gzip 32558, 1170 declaration blocks, all 21 per-area sheets within budget. The measurement is recorded beside the earlier ones in the gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes both root causes behind the failing JavaScript Build run (36225064763) on the
feature/query-states-and-a11ybranch, so #338's checks can go green. Stacked onto that branch — merge it there, not intomain.Fixed
sourceshard failedverify-api-docsbecause the newDataTableStatusmembers reached the public./DataTablessubpath without TSDoc. Each member now documents what the table renders in that state.verify-package-archivebecause the new rules pushed the published aggregate stylesheet to 32791 gzip bytes, 23 past the reviewed 32 KiB ceiling. The ceiling is deliberately never raised without a compensating reduction, so this ships one: the per-file separator comment inside the published stylesheets drops its dash run. Measured on the packed archive: 203689 raw bytes, 32558 gzip bytes, 1170 declaration blocks, and all 21 per-area stylesheets within budget.Verification
node scripts/verify-api-docs.mjs— every reachable public declaration and member documented.yarn workspace @cratis/components pack+node scripts/verify-package-archive.mjs <tgz>— aggregate and per-area budgets pass with the numbers above.yarn workspace @cratis/components run ci— the failing shard's own command: lint, build, 480 test files / 1747 tests, story typechecks, renderer contracts, package-graph report, all green.Nothing was verified beyond that locally: the four renderer-adapter typecheck legs were not rebuilt here — their prior run passed every step before the archive-budget step these commits address.