Add ARCCHR0006 for reactors that return commands without a replay decision - #76
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arc for TypeScript 0.36.0 adds ARCCHR0006, the counterpart of the Arc for .NET analyzer that warns when a reactor executes a command without a replay decision. npm publication remains disabled.
Added
@cratis/eslint-plugin-arc-core'srecommended-type-checkedpreset. It reports a Chronicle@reactor()event handler that returns an Arc@command()without a replay decision:@onceOnly()on the reactor or handler, or a@replay()handler for the same event. Replaying the reactor would otherwise execute the command again.asynchandlers, returned arrays and tuples, and helpers in the same class whose result the handler returns, including class-expression reactors..d.tsfiles, or commands executed manually through an Arc server. The ARCCHR0006 page lists these limits.Changed
recommended-type-checkedcan see new ARCCHR0006 diagnostics on reactors that return commands without@onceOnly()or@replay().Refs #74