Repository navigation
Add Claude subscription access with a separate Claude Code profile - #495
Merged
Merged
Conversation
ahmad-ajmal
marked this pull request as ready for review
October 21, 2026 08:38
ahmad-ajmal
changed the base branch from
feature/session-based-browser
to
V1.4.4
October 21, 2026 08:39
Signed-off-by: ahmad-ajmal <ahmadajmal1514@gmail.com>
Signed-off-by: ahmad-ajmal <ahmadajmal1514@gmail.com>
Signed-off-by: ahmad-ajmal <ahmadajmal1514@gmail.com>
Signed-off-by: ahmad-ajmal <ahmadajmal1514@gmail.com>
Signed-off-by: ahmad-ajmal <ahmadajmal1514@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connect a Claude subscription from onboarding or Model settings using Sign in with Claude. Authentication and text/image inference use the official Claude Code CLI in a separate CraftBot profile.
Preserve the standalone Claude Code login. Disable CLI tools, MCP servers, hooks and session persistence, and honor CraftBot's selected reasoning setting.
Keep Disconnect and sign-in recovery available when saved authentication is invalid. Verify logout before removing the connection flag; errors never silently switch to a paid API key.
Run live CLI status checks outside the browser event loop and settings lock. Serialize complete settings mutations and use atomic file replacement to preserve concurrent changes.
Order model persistence, activation and rollback across browser clients. Cancel and invalidate pending Claude sign-ins on Disconnect, including late status checks and activation callbacks.
Use the documented default
claude auth login, verified to start authorization with installed CLI 2.1.50.Match context reservations to the output cap actually sent. Correct stale OmniRoute test expectations and the existing lint errors.
See the validation report for evidence and screenshots.
Final closure validation
1,169 Python tests passed: 1,104 subscription, settings-transaction, reinitialization, factory, LLM, context-budget, Supabase and WebSocket tests, plus 65 Mini Browser settings regressions.
13 new concurrency regression cases cover save/activation order, rollback, login invalidation at every phase, failed process cancellation and the complete disconnect/reconnect workflow through the model factory.
4 browser regression tests passed using real onboarding and Model settings components with an isolated transport.
Frontend production build, TypeScript, repository-wide Python lint, changed-code formatting, compilation and whitespace checks passed. The existing bundle-size warning remains.
Installed Claude Code 2.1.50 against a local stub confirmed Off disables thinking and High sends adaptive thinking with high effort.
Bounded closure review found no remaining code blockers. Both reported races are fixed.
Remaining acceptance
Real-account acceptance is still needed for authenticated private-profile browser sign-in, successful live text/image inference, authenticated Disconnect/reconnect, and preservation of standalone authentication during that logout. The final isolated-profile sign-in was launched, but the user could not sign in during this pass. The pending CLI was stopped; cleanup left the private profile logged out with no connection flag, and standalone authentication remained connected. Mocked tests, browser fixtures and the local stub do not establish these results.
This PR targets
V1.4.4.