Repository navigation
Add per-file locks for write_file and stream_edit - #447
Merged
Merged
Conversation
zfoong
marked this pull request as ready for review
September 9, 2026 03:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Added a lock for write file and stream edit.
Why:
Only one of them can access the same file at the same time. This prevents corruption and errors if they edit the same information.
This is currently untested, but i will be testing it soon. I expect some errors.
UPDATE: I've tested using the craftbot as usual, nothing has broken so far? Any errors i got are related to other things currently in development like the Agent App operation/evolving,