Skip to content

fix(tui): replace violet accent with banner green - #40

Merged
echobt merged 3 commits into
mainfrom
fix/banner-green-accent
Sep 7, 2026
Merged

fix(tui): replace violet accent with banner green#40
echobt merged 3 commits into
mainfrom
fix/banner-green-accent

Conversation

@echobt

@echobt echobt commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace violet with the reference banner's exact dominant green #1F4945.
  • Keep focused green text readable on a contrasting #F5F5F5 backing. Preserve semantic success/diff colors.
  • Update theme documentation and source renderers; existing exported images are historical, not regenerated.

Test plan

  • Core style tests: 12 passed, including contrast assertion.
  • TUI unit/headless tests: 1044 passed, 7 existing ignored.
  • Components/capture tests: 93 and 46 passed.
  • cargo fmt --all -- --check; git diff --check; Python renderer syntax.
  • Full workspace, audit and CI not run/waited for this palette-only change, as requested.

Attestation

  • Security: visual-only change, no auth/exec/path/network behavior changes.
  • Product-facing errors: unchanged.
  • TUI: unit and narrow/wide headless render assertions passed; live authenticated session not exercised.
  • Tests added/updated with actual color and contrast assertions.
  • No secrets included.

Risk

Dark banner green needs a light focus backing for readable contrast. No release/version change. CI is not awaited and this PR is not auto-merged, per user request.

Use the banner's #1F4945 green and contrasting focus backing.
Update palette assertions, headless checks and theme documentation.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Sep 7, 2026

Copy link
Copy Markdown

Greptile Summary

This change introduces two focused-control readability regressions. Selected labels in several pickers now use a dark green foreground on a dark selection bar, and active question tabs use theme accents on a fixed near-white backing that is unreadable in Ocean Dark and Monokai.

Merge safety: not safe to merge until these focused controls use accessible color pairings.

Confidence Score: 3/5

The change is not safe to merge because two independently reproduced display defects make focused interactive choices difficult to read.

Two independent, execution-confirmed failures affect visible keyboard-navigation controls.

Files Needing Attention: src/cortex-core/src/style.rs and src/cortex-tui/src/views/question_prompt.rs need accessible focused-state color treatments.

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex produced proof for a posted P1 finding, and the reviewer can consult the corresponding review comment for details.
  • T-Rex produced proof for another posted P1 finding, with the associated review comment detailing the finding.
  • T-Rex produced proof for a third posted P1 finding, linked to its review comment with the finding details.
  • T-Rex executed the pr40_selection_contrast_validation test and verified the current-PR output matched expectations, and the test passed.
  • T-Rex ran the pr40_question_tab tests, including contrast validation, and confirmed the contrasts were below 4.5:1 per the validator, with the independent calculation matching the results.

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "fix(tui): replace violet accent with ban..." | Re-trigger Greptile

Comment thread src/cortex-core/src/style.rs
Comment thread src/cortex-tui/src/views/question_prompt.rs Outdated
echobt and others added 2 commits September 7, 2026 19:51
Remove source-quality regressions without changing the banner green
palette or its accessible focus backing.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Use readable backing for selected labels and derive themed focus backing
from accent luminance. Cover focused cells across built-in themes.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@echobt
echobt merged commit 8672e67 into main Sep 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant