Refuse mistyped skill tools and whitespace grant ids with 400 - #546
Merged
davidmckayv merged 2 commits intoSep 15, 2026
Merged
davidmckayv merged 2 commits into
davidmckayv merged 2 commits into
Conversation
POST /skills silently dropped non-string tool entries, so a client bug installed a skill declaring nothing and answered success, and a non-boolean global could mint a deployment-wide skill. Every tool entry must now be a non-empty string and global a boolean. Component grant and function routes accepted whitespace-only ids, writing grant rows and audit rows naming nothing; all three now trim and refuse blanks before the store.
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 15, 2026 09:08
davidmckayv
approved these changes
Sep 15, 2026
davidmckayv
left a comment
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Code-verified clean; CI green on this sha.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /skills silently dropped non-string tool entries, so a client bug installed a skill declaring nothing and answered success, and a non-boolean global could mint a deployment-wide skill. Every tool entry must now be a non-empty string and global a boolean. Component grant and function routes accepted whitespace-only ids, writing grant rows and audit rows naming nothing; all three now trim and refuse blanks before the store.
Verified: bun test server/tests/component-grants-skills-validation.test.ts — 11 pass, 0 fail. Biome lint and format clean.