Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion server/src/audit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,10 @@ export async function recordAuditEvent(
export function createAuditStore(database: Database): AuditStore {
return {
insert: async (event) => {
await database.insert(auditEvents).values(event);
await database.insert(auditEvents).values({
...event,
payload: redactAuditPayload(event.payload) as Record<string, unknown>,
});
},
};
}
Expand Down
25 changes: 25 additions & 0 deletions server/tests/audit.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { readdir, readFile } from "node:fs/promises";
import { createApp } from "../src/app";
import {
auditEventTypes,
createAuditStore,
recordAuditEvent,
redactAuditPayload,
} from "../src/audit";
Expand Down Expand Up @@ -95,6 +96,30 @@ describe("audit payload redaction", () => {
},
]);
});

test("a direct store insert is redacted too", async () => {
// Redaction used to live only in recordAuditEvent, so a direct insert()
// stored secrets in cleartext. The store is the last line of defence.
let stored: unknown;
const store = createAuditStore({
insert: () => ({
values: async (event: unknown) => {
stored = event;
},
}),
} as never);

await store.insert({
eventType: "credential.created",
targetType: "credential",
targetId: "credential-1",
payload: { apiKey: "plaintext-key", provider: "openai" },
} as never);

expect(stored).toMatchObject({
payload: { apiKey: "[REDACTED]", provider: "openai" },
});
});
});

describe("audit event immutability", () => {
Expand Down