Skip to content

allowed_groups is documented as a channel access control but is never enforced #82

Description

@andreolf

Package channels store allowed_groups (server/src/tenant-package.ts, db/schema/core.ts) and the docs describe it as deciding which people a channel is open to, but no code reads the column (grep finds only tests). It is not currently exploitable, because synchronizeTenantPackage also writes no membership rows for package channels and every channel route gates on membership — so package channels are unreachable rather than open. The moment membership is wired up for package channels, a control the docs promise will silently not exist.

Fix: enforce allowed_groups at the channel-access check, or stop documenting it as an access control until it is.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions