Skip to content

Refactor: Consolidate duplicate PID controller implementations into a single module #378

Description

@GaneshPatil7517

tools/pidmayuresh.py and tools/pidmayuresh3.py implement the exact same PID controller with the exact same tryparam defaults, the same function signature pid_controller(state, ym, sp, Kp, Ki, Kd, sigout, cin, low, up), and the same logic. The only difference is pidmayuresh.py uses logging.debug() while pidmayuresh3.py uses print(). One of these files should be removed, or they should be consolidated.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions