chore: remove one-off debug scripts and status docs from repo root (96 → 57 files) - #743
Merged
Merged
Conversation
…m repo root The 2026-08-24 fleet structure audit found softwarecatalog carrying 63 root files beyond the nextcloud-app-template baseline — the largest root in the fleet, against a fleet median of ~40. Most were one-off investigation scripts and status notes from finished work. Removed (39 files, ~6.5k lines): - 27 one-off scripts: check_*.php, debug_*.php, find_objects_*.php, cleanup_*.php, enhance_archimate_service.php, and the test_*/test-* shell and PHP scripts superseded by test_archimate_unified.sh or by the Newman/Postman suite. - test_small_archimate.xml — an unreferenced fixture; the kept ArchiMate suite reads lib/Settings/GEMMA_release.xml instead. - 11 point-in-time status docs: AMEF_TESTING.md, ARCHIMATE_IMPORT_FIX.md, ARCHIMATE_PROJECT_STATUS.md, CIRCLE_TEST_DOCUMENTATION.md, FIX_VERIFICATION_SUMMARY.md, INTEGRATION_TEST_RESULTS.md, KOPPELINGEN_GEBRUIK_REFACTOR.md, README_DEBUG.md, WORKFLOW-UNSTABLE-RELEASE.md, Openregister.md, aanvullende-informatie.md is retained (issues.md links it). Deliberately KEPT, because each is live-referenced: - test-setup.sh — invoked as `bash stackiq/test-setup.sh` by .claude/commands/test.md and six persona test skills. - compare_archimate.php — documented in docs/ARCHIMATE_QUICK_TEST.md and docs/ARCHIMATE_TESTING_GUIDE.md (4 call sites). - compare_archimate.py — invoked by test_archimate_unified.sh:260. - test_archimate_unified.sh — the consolidated ArchiMate suite. - issues.md — NOT scratch. 3,659 lines tracking 137 VNG IGS issues and 1,026 acceptance criteria; README.md calls it "the master file", it is listed in .distignore, and nine .claude commands/skills read it to drive the persona test suite. - BUG_FIX_ORGANISATION_USER_ASSIGNMENT.md — named by open task 4.1 of the active openspec change organisation-parent-hierarchy-rbac-fix. test_archimate_unified.sh's header comment is updated so its "this replaces" list reads as history rather than pointing at files that no longer exist. Root file count: 96 -> 57. Refs ADR-099 Decision 2 (the repository root is a closed set).
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 720/720 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-24 22:49 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2026-08-24 fleet structure audit found softwarecatalog carrying 63 root files beyond the
nextcloud-app-templatebaseline — the largest root in the fleet (fleet median ~40, template 38). Most were one-off investigation scripts and status notes from finished work.Removed — 39 files, ~6.5k lines. 27 one-off scripts (
check_*.php,debug_*.php,find_objects_*.php,cleanup_*.php, and thetest_*/test-*scripts superseded bytest_archimate_unified.shor the Newman suite), one unreferenced fixture, and 11 point-in-time status docs.What was deliberately kept, and why
I checked every candidate for inbound references before deleting. Six were not safe to remove:
test-setup.shbash stackiq/test-setup.shin.claude/commands/test.md+ 6 persona skillscompare_archimate.phpdocs/ARCHIMATE_QUICK_TEST.md,docs/ARCHIMATE_TESTING_GUIDE.md(4 call sites)compare_archimate.pytest_archimate_unified.sh:260test_archimate_unified.shissues.mdBUG_FIX_ORGANISATION_USER_ASSIGNMENT.mdorganisation-parent-hierarchy-rbac-fixchangeissues.mdwas on the original delete list and should not have been. It is 3,659 lines tracking 137 VNG IGS issues and 1,026 acceptance criteria;README.mdcalls it "the master file", it is listed in.distignore, and nine.claude/commands and skills read it to drive the persona test suite. Removing it would have gutted the testing workflow. It was caught by a post-deletion reference sweep, not by the initial classification — worth noting because the file's name looks exactly like scratch.test_amef_simple.sh,test_archimate_export.shandtest_optimized_api.shwere removed but are still named intest_archimate_unified.sh's header — only in its "this replaces" history list. That comment is reworded here so it reads as history rather than pointing at live files.Root file count: 96 → 57.
Refs ADR-099 Decision 2 (the repository root is a closed set) —
ConductionNL/hydra#616.