fix(walkthrough): end the tour on a call to action that opens the docs - #724
Merged
Conversation
The final step had no `task`, so the guided tour stopped without telling the user where to go next. It now closes on the documentation, per the fleet rule that a walkthrough's last step points somewhere. The CTA targets the `Documentation` nav item that already exists in this app's menu, so it lands on a real destination rather than a URL invented for the copy. The same step also carried voice defects the shared writing skill bans: "Nicely done" is praise rather than voice, the em-dash is stripped fleet-wide, and "reopen this tour anytime from the … menu" is housekeeping in the one line a user is most likely to act on. The title now states what the user actually has, and the body says what to do with it.
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 720/720 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-24 09:48 UTC
Download the full PDF report from the workflow artifacts.
development renamed the create-organisatie step's register from `voorzieningen` to `stackiq`; this branch rewrote the final step to end on a call to action. Both are correct and neither supersedes the other, so the resolution takes development's register and this branch's final step. Also removed the em-dash from the create-organisatie body while resolving. It is the same voice defect this branch exists to fix, sitting two lines above the step being fixed, and leaving it would have shipped a PR that strips an em-dash from one step and steps over one in its neighbour.
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 720/720 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-24 10:58 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guided tour's final step had no
task, so it stopped without telling the user where to go next. It now closes on the documentation, per the fleet rule that a walkthrough's last step points somewhere.The CTA targets the
Documentationnav item that already exists in this app's menu, so it lands on a real destination rather than a URL invented for the copy. I checked the URL resolves (HTTP 200) before pointing users at it.The same step carried voice defects
Measured against the shared
writingskill (ConductionNL/hydra#610):Nicely done—reopen this tour anytime from the … menuThe title now states what the user actually has; the body says what to do with it. No em-dashes, every sentence under 16 words, the task starts with a verb.
Verification
JSON parses, the final step has a
task, and its target resolves to aDocumentationmenu entry that exists in this manifest. CI's manifest-validation gate covers the schema.Part of a fleet sweep across the 9 apps that ship a walkthrough. The survey read each manifest from
origin/development, not from local working trees, because those sit on other sessions' branches and give a wrong answer.