refactor(deps): inject OpenRegister instead of looking it up (ADR-083)

[rubenvdlinde]

5 file(s) reached OpenRegister through $this->container->get(...) on an unconditional path — no availability check, no degrading catch. The dependency was announced nowhere: not in the constructor, not in the use block, not in any type. It appeared mid-method, as a string.

Now constructor-injected and typed. Behaviour is unchanged — same object, same container, resolved at construction instead of at first use. ContainerInterface is dropped only where nothing else used it.

Deliberately not converted, because they are correct as written (ADR-083 rule 1's exception): lookups behind isInstalled()/getInstalledApps(), and lookups whose catch degrades rather than rethrows. Converting those would make the service unconstructable without OpenRegister and turn a clean message into a 500.

Verified per file: php -l clean, and gate-66's lookup check reports zero remaining findings for each file changed.

gate-66 for this app: 23 → 8.

[github-actions]

Quality Report — ConductionNL/softwarecatalog @ cfbbdd1

Check	PHP	Vue	Security	License	Tests
lint	✅
phpcs	✅
phpmd	❌
psalm	❌
phpstan	❌
phpmetrics	✅
eslint		✅
stylelint		✅
build		✅
check-manifest		✅
check-vue-demi		✅
test-l10n		✅
format		✅
composer			✅	✅ 130/130
npm			✅	✅ 704/704
app:check-code	⏭️
info.xml	✅
REUSE	❌
PHPUnit					❌
Newman					⏭️
Playwright					❌
Hydra gates					❌

---

Quality workflow — 2026-08-14 19:05 UTC

Download the full PDF report from the workflow artifacts.

[rubenvdlinde]

Marked draft — not mergeable as it stands, same cause as decidesk/pipelinq/shillinq.

Removing ContainerInterface shifts every positional argument after it, so unit tests constructing these services hand the wrong mock to the next parameter. CI shows the PHPUnit matrix red across all six cells.

7 test file(s) here construct the classes this PR changes and need updating to the new signature first.

The lib/ side is complete and verified — php -l clean per file, gate-66 lookup findings zero for every file changed. Kept open so that work is not lost; docudesk #461 shows the fix shape on a 2-file example.

[rubenvdlinde]

Blocked on a missing prerequisite, not on this diff

Piloting the test fixes surfaced why every rollout PR goes red the same way, and it is not the conversion:

OpenRegister is not autoloadable in unit tests. This repo's tests/bootstrap.php declares stubs for OpenRegister events and interfaces precisely because the real classes are absent in the standalone composer environment. Tests that need ObjectService therefore either wire it through a ContainerInterface mock (untyped, so anything passes) or declare a local stub interface in the test file.

Constructor-injecting the concrete OCA\OpenRegister\Service\ObjectService type removes that escape hatch: PHPUnit cannot mock a class it cannot load.

Only openconnector ships tests/stubs/OCA/OpenRegister/Service/ObjectService.php. The other seven apps do not, which is exactly the set of red PRs.

So the recipe has a step nobody had written down

1. add an ObjectService test stub + autoload it from tests/bootstrap.php
2. transform lib/ ← this PR, complete and verified
3. update the test constructions

And step 1 is a decision, not a chore

openconnector's stub declares 10 of the real class's 59 methods. Vendoring seven more copies means seven doubles drifting away from a class none of them own — and a stale double on this fleet has already reported a security hole that did not exist.

The alternative is OpenRegister publishing a contract (an interface, or a tests/stubs package consumers require) so there is one definition rather than eight.

Left as a draft deliberately. lib/ is complete: php -l clean per file, gate-66 lookup findings zero for every file changed. It should land once step 1 is settled — not before.