Skip to content

fix(install): import the register on a FRESH install, not only on upgrade #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenvdlinde merged 1 commit into from
Aug 12, 2026
Merged

fix(install): import the register on a FRESH install, not only on upgrade #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,24 @@ Vrij en open source onder de EUPL-licentie.
-->
<step>OCA\SoftwareCatalog\Repair\RenameDutchCatalogColumns</step>
</post-migration>
<!--
FRESH INSTALL. Nextcloud does NOT run post-migration on a first install:
`Installer::installAppLastSteps()` guards both the pre-migration and
post-migration blocks with `if ($previousVersion !== '')`, and only
`repair-steps/install` runs unconditionally afterwards. Until this block
existed a brand-new SoftwareCatalog install ran NONE of the steps above,
so InitializeSettings never fired and the register was never imported —
despite that step's own docblock saying it initialises settings "on
install/upgrade".

Only InitializeSettings belongs here. MigrateContactsToNc,
BackfillContractApprovalState and RenameDutchCatalogColumns are all
migrations or backfills over data a fresh install does not yet have, so
they stay upgrade-only rather than running against an empty database.
-->
<install>
<step>OCA\SoftwareCatalog\Repair\InitializeSettings</step>
</install>
</repair-steps>

<settings>
Expand Down
Loading