Skip to content

fix: declare NC 32 as the floor — openregister cannot install below it - #451

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/nc32-floor-softwarecatalog
Aug 7, 2026
Merged

fix: declare NC 32 as the floor — openregister cannot install below it#451
rubenvdlinde merged 1 commit into
developmentfrom
fix/nc32-floor-softwarecatalog

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What changed

appinfo/info.xml min-version 28 → 32. src/manifest.json lists "openregister" as a required dependency.

CI is unchanged — this repo already pins nextcloud-test-refs: ["stable32"], so nothing about what runs changes. What changes is the range advertised in the app store, which currently promises NC28 for an app whose data layer cannot install there.

The defect

openregister raised its own floor this morning — <nextcloud min-version="32" max-version="34"/>, commit 8d5181f7a (openregister#2378), "require Nextcloud 32, which is where the ContextChat interfaces exist". Its lib/ContextChat/ContentProvider.php implements OCP\ContextChat\IContentProvider, and core does not have that interface before NC32. That raise is correct and is not being reverted here.

The consequence lands on every app that depends on openregister but still tests on stable31:

Enabling app: openregister
App "Open Register" cannot be installed because it is not compatible with this version of the server.
##[warning]Failed to enable openregister, continuing...

The enable failure is only a ::warning:: (shared quality.yml, "Install Nextcloud" step), so the run continues without its data layer and every /apps/openregister/... call returns Nextcloud's HTML 404 page.

This was measured, not inferred

  • One unchanged commit's job passed at 08:05 and failed at 08:35, with zero code change in between — the only thing that moved was openregister's floor.
  • Re-running development's own Newman on yesterday's commits: decidesk 93 → 191 failures, larpingapp 10 → 22.
  • docudesk was immune, and only because it already tests stable32 only.

stable31 is removed, not "dropped for coverage"

A stable31 leg was exercising a configuration that cannot exist: the app under test declares openregister as a hard dependency, and openregister cannot install there. Nothing was being covered on that leg — its red said nothing about this app's code. Removing it corrects an impossible configuration. It does not reduce coverage.

The matrix is not widened either: no stable33 is added where it was not already present.

The ordering bug in the same family

Membership was not the only problem. In the shared quality.yml, three jobs pin the first entry rather than iterating the list:

job line server
newman 1748 fromJSON(inputs.nextcloud-test-refs)[0]
playwright 2024 fromJSON(inputs.nextcloud-test-refs)[0]
journeydoc-capture 2775 fromJSON(inputs.nextcloud-test-refs)[0]

(phpunit iterates the whole list, so it was broken by membership; the coverage-guard and coverage-artifact steps at 1644/1671/1684 are also [0]-pinned.)

So wherever stable31 sat first, those three jobs ran entirely on the version openregister cannot load. doriath had already reordered for exactly this reason.

Precedent

This is the same defect as openconnector#1173, which declared min-version="28" while its own <app>openregister</app> dependency required 32 — advertising, in the app store, a range it could not deliver. This PR follows that shape.

Scope

No app version bump — only the supported-server range and the CI matrix change, so there are no occ upgrade implications.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/softwarecatalog @ 5a695e4

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
build
check-manifest
check-vue-demi
test-l10n
composer ✅ 128/128
npm ✅ 718/718
PHPUnit
Newman ⏭️
Playwright
Hydra gates

Quality workflow — 2026-08-07 10:12 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 0bb4d3d into development Aug 7, 2026
29 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/nc32-floor-softwarecatalog branch August 7, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant