chore(deps): remove dead runtime deps — bare axios, @fortawesome, @vue/compat - #449
Merged
Merged
Conversation
…e/compat None of these are imported anywhere in src/. Measured with a local grep over the checked-out tree, positive-controlled so an empty result means a real absence and not a broken search: the same grep finds 66 files importing @nextcloud/axios in openregister. bare "axios" 0 imports the apps use @nextcloud/axios @fortawesome/* 0 imports @vue/compat 0 imports @vue/compat is worth a note. A naive grep DOES hit it in webpack.config.js — but only inside comments recording that it was REMOVED: "build runs on the REAL Vue 3 runtime — NOT @vue/compat" "PURE VUE 3 (ADR-066): the @vue/compat MODE-2 compiler shim is gone" A checker that greps a bare string matches every comment about a thing as readily as a use of it. Confirmed dead by reading the hits, not counting them. NOT removed from opencatalogi, which genuinely uses both: 2 files import bare axios and 3 import @FortAwesome. Same manifest line, opposite verdict — so this was decided per repo, not swept. Lockfile regenerated with npx npm@10.8.2, never --legacy-peer-deps.
Contributor
Quality Report — ConductionNL/softwarecatalog @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| composer | ✅ | ✅ 121/121 | |||
| npm | ✅ | ✅ 718/718 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-07 08:30 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these are imported anywhere in
src/.Evidence
Measured with a grep over the checked-out tree, positive-controlled so an empty result means a real absence rather than a broken search — the same grep finds 66 files importing
@nextcloud/axiosin openregister.src/axios@nextcloud/axios@fortawesome/*@vue/compat@vue/compatis worth a noteA naive grep does hit it in
webpack.config.js— but only inside comments recording that it was removed:A check that greps a bare string matches every comment about a thing as readily as a use of it — the same failure that produced false ADR-040 findings earlier in this programme. Confirmed dead by reading the hits, not counting them.
Deliberately NOT applied to opencatalogi
opencatalogi genuinely uses both: 2 files import bare
axios, 3 import@fortawesome. Identical manifest lines, opposite verdict — decided per repo rather than swept.Lockfile regenerated with
npx npm@10.8.2, never--legacy-peer-deps.