fix(security): wave-3 critical fixes - #365
Merged
Merged
Conversation
C1: ContactpersonenController::updateUserGroups — add admin/org-admin gate; any authed user could previously self-assign write-tier groups (privilege escalation) C3: SettingsService::determineOrganisationType — fix strtolower(getName() === true) type-coercion bug that returned empty string, causing all orgs to be typed as Leverancier Other C2/C4/C5/C6/C7 findings were already resolved in main prior to this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes remaining wave-3 CRITICAL findings from
/tmp/triage-softwarecatalog.mdthat were still present onmain. Thedevelopmentbranch had all 7 bugs;mainhas already resolved C2/C4/C5/C6/C7 via prior commits.ContactpersonenController::updateUserGroups— Add admin/org-admin gate ($this->groupManager->isAdmin()+gebruik-beheerder/aanbod-beheerdergroup check). The method was@NoAdminRequiredwith no auth check at all — any authenticated user could grant themselves or others write-tier catalog groups (privilege escalation).SettingsService::determineOrganisationType— Fixstrtolower($organisation->getName() === true)type-coercion bug. The=== truecomparison turns the string name into a boolean (false), whichstrtolowercoerces to'', makingstrposnever match — all organisations were classified asLeverancierregardless of name.Changes C2/C4/C5/C6/C7 are already resolved on
mainand were not re-applied.developmentbranch also received all 7 fixes at commit91bf0e4.Test plan
PATCH /contactpersonen/{username}/groupsreturns 403gebruik-beheerdergroup member; group update succeedsdetermineOrganisationTypereturns'Gemeente'(not'Leverancier')