refactor: Replace GenericObjectTable with CnIndexPage - #196
Merged
Conversation
…sion suppressions Removed all 42 @SuppressWarnings(PHPMD.ElseExpression) annotations. Refactored ~206 else expressions to early returns, guard clauses, default-then-override, and ternary patterns. 183 violations remain in complex nested structures (try/catch boundaries, deeply nested chains) that require careful manual refactoring.
… errors Migration from custom 1,420-line GenericObjectTable component to the shared CnIndexPage from @conduction/nextcloud-vue: - Rewrite ObjectIndex.vue to use CnIndexPage with sidebar integration, sorting, pagination, search, filtering, and modal system wiring - Delete GenericObjectTable.vue (1,420 lines) and 3 dead view files (VoorzieningIndex, ContactpersoonIndex, ContractIndex) that were never referenced in Views.vue routing - Fix all 46 ESLint errors: remove unused t/n imports from 18 files, add scoped attribute to 9 style tags, suppress CnDashboardPage import - Fix PHPCS formatting errors from development merge (auto-fixed) - Add .license-overrides.json for @fortawesome/free-solid-svg-icons (CC-BY-4.0 AND MIT compound license) - Remove push trigger from CI workflow to prevent double runs Quality status: PHPCS 0/0, Psalm 0, ESLint 0 errors (7 warnings)
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (120 total)
npm dependencies (582 total)
PHPUnit Tests
Code coverage: 0% (0 / 270 statements) Integration Tests (Newman)
Generated automatically by the Quality workflow.
|
…fig-recommended-vue
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (120 total)
npm dependencies (582 total)
PHPUnit Tests
Code coverage: 0% (0 / 270 statements) Integration Tests (Newman)
Generated automatically by the Quality workflow.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Net result: -2,164 lines, ESLint 78→0 errors, all quality checks pass
Test plan
🤖 Generated with Claude Code