feat: OpenSpec implementation - #194
Merged
Merged
Conversation
Show NcEmptyContent empty state when OpenRegister is not installed, with install button for admins. Add ESLint rule enforcing scoped styles in Vue files, move global CSS to src/assets/app.css.
Support: support@conduction.nl SLA: sales@conduction.nl
Add CnVersionInfoCard as first section with support footer, pass app version to template, use app-dark.svg instead of core settings icon.
…I imports, translation files - Add @nextcloud/l10n import in main.js - Add per-component import for 24 <script setup> Vue files - Fix wrong app ID (opencatalogi -> softwarecatalog) in 20 t() calls - Wrap 80+ hardcoded strings, fix 3 Dutch keys in en.json - Create l10n/en.json and l10n/nl.json with 134 translation keys
- Add Testing section: code quality workflow (8 checks), API tests (454 assertions), agentic browser tests (1,026 acceptance criteria across 137 issues, 7 personas) - Add Issue Management paragraph explaining VNG's late issue filing (Oct 2025) without acceptance criteria, and our markdown shadow issue system - Add Required Repositories section (OpenRegister, OpenCatalogi, NL Design, Tilburg WOO UI, MyDash) - Add Installation guide (Docker, app enable order, data import, frontend builds) - Move SWC-specific test/update skills into this repository - Assign all 171 issues to persona skill files — zero coverage gaps
…r doc comments, camelCase vars, ternaries, named params
…ed methods, type errors, update config
…ec-implementation
- Fix named argument mismatches in ArchiMate services (propDefMap) - Fix undefined $propRef variable in ArchiMateExportService - Fix $this->_appName → $this->appName in SettingsService - Fix empty() on boolean in SettingsService - Add @psalm-suppress for Doctrine PostgreSQLPlatform in OrganizationSyncService - Fix PHPCS formatting in OrganizationHandler
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (120 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
composer check:strictbefore merging