Skip to content

settings: getVersionInfo() repeats the app-semver vs register-content-version comparison bug (misleading 'Up to date' in admin UI) #397

Description

@rubenvdlinde

Found while fixing #391 (PR #396). SettingsService::getVersionInfo() — the /api/settings/version diagnostic rendered by VersionInformation.vue as '✓ Up to date' / '⚠ Update needed' — compares the app's own semver against the register content version stored on the same slot, the same category error that broke shouldLoadSettings() (version_compare("0.2.17", "2.3.1+frag...") is meaningless). Admins are therefore shown an unreliable up-to-date indicator. Fix: compare the currently computed content version (computeConfigVersion(), now including the monolith hash) against the stored one. Deliberately left out of #396's scope.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions