Skip to content

[MEDIUM] M1: manualImport always returns HTTP 400 — successful imports appear as failures #341

Description

@rubenvdlinde

Severity: MEDIUM

Location: lib/Controller/SettingsController.php lines 1020–1023 (manualImport)

Description:
The success branch of manualImport is an empty if block:

if ($result['success'] === true) {
    // empty
}
return new JSONResponse($result, 400);

Every response — including successful imports — returns HTTP 400. The UI therefore always displays the import as failed, regardless of the actual outcome.

Suggested fix:

return new JSONResponse($result, $result['success'] === true ? 200 : 400);

Source: deep team-reviewer pass 2026-05-27

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions