fix(manifest): register the icons the menu names, and point it at a page that exists - #75
Closed
rubenvdlinde wants to merge 1 commit into
Closed
fix(manifest): register the icons the menu names, and point it at a page that exists#75rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…age that exists Closes gates 53 and 60. gate-60 (icon-vocabulary, 5). All three menu icons were legacy `icon-*` CSS classes, and the register's Dashboard schema used the filled `ViewDashboard` where ADR-077 Tier A requires the outline. Migrated to the canonical names: dashboard -> ViewDashboardOutline (Tier A), template -> FileReplaceOutline (Tier B), settings -> CogOutline (Tier A). An unbridged `icon-*` renders as an invisible white glyph on NC34+ light themes. The fifth finding was the load-bearing one: `src/main.js` never called `registerIcons()`. CnIcon resolves a manifest icon name ONLY through that registry and has no fallback — an unregistered name renders nothing at all: no glyph, no placeholder, no console error. So migrating the three names without registering them would have traded an invisible glyph for a missing one. Adds `src/icons.js` with the three components and wires the call before mount. All three verified to exist in vue-material-design-icons. The same legacy class was also hardcoded in the SERVER-side builder: ManifestController::buildManifest() emitted `icon-home` for every runtime menu entry — the wrong concept as well as a legacy class, since those entries are dashboards. That is not in gate-60's scope (it reads the JSON manifests, not PHP), but it is the same defect on the path users actually see, so it moves to ViewDashboardOutline too. gate-53 (effective-manifest-crossref, 1). The one menu entry LaunchPad ships pointed at `/dashboards`, which matches no page: this stub's only dashboard page is `/dashboards/:id`, and the runtime builder emits `/<slug>`. Retargeted to the page id `dashboard-detail`, which is the pairing the server itself emits — buildManifest() sets each menu entry's route to its page's id while the page carries the path. There is deliberately no `/dashboards` index page; the rationale now lives in the page's own _note, because the v2 schema sets additionalProperties:false on menu entries and rejects a note there. Verified: gates 53 and 60 report 0 against this tree and still report 1 and 5 against origin/development. check:manifest valid, eslint 0 errors, 638 unit tests pass, webpack build ok.
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 9, 2026 14:32
Contributor
Author
|
Superseded by #77 — same commit, rebranded to |
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| composer | ✅ | ✅ 102/102 | |||
| npm | ✅ | ✅ 548/548 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-09 14:38 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes hydra gates 53 and 60 — 6 findings.
Measured
Gate package
48c88ba1e0d049f8f38538c33e790d3e603c55d0.Both checkers still report 1 and 5 against
origin/development.The load-bearing finding
Four of gate-60's five findings are name migrations. The fifth is a live defect:
src/main.jsnever calledregisterIcons().CnIconresolves a manifest icon name only through that registry and has no fallback — an unregistered name renders nothing at all: no glyph, no placeholder, no console error.So migrating
icon-dashboard→ViewDashboardOutlinewithout registering it would have traded an invisible glyph for a missing one.src/icons.jsregisters the three components; all three are verified present invue-material-design-icons.Migration (ADR-077)
dashboardsicon-dashboardViewDashboardOutline(Tier A)adminTemplatesicon-template(unbridged)FileReplaceOutline(Tier B)adminSettingsicon-settingsCogOutline(Tier A)DashboardViewDashboardViewDashboardOutline(Tier A MUST)Also fixed outside gate scope:
ManifestController::buildManifest()hardcodedicon-homefor every runtime menu entry — the wrong concept as well as a legacy class, since those entries are dashboards. gate-60 reads the JSON manifests, not PHP, so it never saw it; it is the same defect on the path users actually see.gate-53
The single menu entry LaunchPad ships pointed at
/dashboards, which matches no page — this stub's only dashboard page is/dashboards/:id, and the runtime builder emits/<slug>. Retargeted to the page iddashboard-detail, which is the pairing the server itself emits (buildManifest()sets each menu entry'srouteto its page's id, while the page carries the path).There is deliberately no
/dashboardsindex page. That rationale lives in the page's own_note, because the v2 schema setsadditionalProperties: falseon menu entries and rejects a note there — which the first attempt at this fix discovered.Checks
check:manifest: validsrc: 0 errorsnpm run build: compiledNo waivers, no excludes, no threshold changes.