fix(gate-100): the rule is the offer at step 2, not the id it is called - #649
Open
rubenvdlinde wants to merge 1 commit into
Open
fix(gate-100): the rule is the offer at step 2, not the id it is called#649rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
ADR-111 rule 4 says the configuration wizard opens by saying what the app is,
then offers the data that lets a reader SEE it work. It does not say what that
step must be called. Gate-100 matched one literal id, `demo-data`, so an app
that satisfied the rule under a better name was judged as having no offer at
all.
Measured on decidiq (2026-08-30). It stopped planting 334 unchosen objects on
install and now ships four example sets an operator picks between (municipality,
association, company board, works council) plus the ADR-111 generated dataset,
all in one `choice` step at index 1 named `example-set`.
Under the id-only rule that read as WARN "setup declares no demo-data step",
and the remedy it printed — declare a step calling `install-demo-data` — would
have replaced a working chooser with the single un-chosen dataset the app had
deliberately stopped shipping. A gate that advises undoing the fix is worse
than no gate.
So the accepted ids are the ones that mean "the offer": `demo-data` for an app
offering one dataset, `example-set` for one offering several. A future name for
the same step belongs in that set, not in a finding.
Nothing else moves. Step 1 must still be `welcome`, the offer must still be at
index 1, an app with no setup block is still not this gate's business, and a
missing offer still WARNs rather than blocks.
Verified: all five existing acceptance arms still pass, plus a sixth that fails
without this change. The gate still FAILs a manifest whose offer sits at index 2
("The app HAS the offer, at index 2"), so the ordering rule is unweakened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-111 rule 4 says the configuration wizard opens by saying what the app is, then offers the data that lets a reader see it work. It does not say what that step must be called. Gate-100 matched one literal id,
demo-data, so an app that satisfied the rule under a better name was judged as having no offer at all.Measured on decidiq (2026-08-30)
It stopped planting 334 unchosen objects on install (decidiq#1024) and now ships four example sets an operator picks between (municipality, association, company board, works council) plus the ADR-111 generated dataset, all in one
choicestep at index 1 namedexample-set.Under the id-only rule that read as:
The remedy it printed — declare a step calling
install-demo-data— would have replaced a working chooser with the single un-chosen dataset the app had deliberately stopped shipping. A gate that advises undoing the fix is worse than no gate.What changes
The accepted ids become the ones that mean "the offer":
demo-datafor an app offering one dataset,example-setfor one offering several. A future name for the same step belongs in that set, not in a finding.Nothing else moves:
welcomesetupblock is still not this gate's businessVerification
All five existing acceptance arms still pass, plus a sixth that fails without this change:
The ordering rule is unweakened: a manifest whose offer sits at index 2 still FAILs, now saying
The app HAS the offer, at index 2.Note on releases, separate from this PR
conduction/hydra-gatesv1.10.0 was tagged 2026-08-27 18:18. The vendored manifest schema refresh to 2.26.0 landed at 22:35 the same day, four hours later, and 51 commits have landed onmainsince the tag, 21 of them touching hydra-gates. So every app's gates currently run against a schema that predates theflowpage type, which fails gates 22 and 53 on decidiq and on any app using that page type. This PR does not cut that release; flagging it because the fix is already onmainand only a release carries it.🤖 Generated with Claude Code