Repository navigation
#3178 InfiniteCanvas Heap Corruption - #3228
Conversation
|
Thanks deanchalk for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Kyaa-dost
left a comment
There was a problem hiding this comment.
@deanchalk Thanks for the PR. It is performing as expected with the reasoning provided in the PR description.
|
Thanks @deanchalk for this PR, sorry it took so long to merge! Do you think it makes sense to somehow limit the zooming or are we just going to hit this anyway? I guess that's your point where we don't know what the limit is and effectively the user will just see what they saw last, eh? |
Yup, and unfortunately the limit seems to be arbitrary and built into the underlying framework, and there isnt an API that exposes it, so I think this is the best experience we can give the user |
Fixes #3178
PR Type
What kind of change does this PR introduce?
-Bugfix
What is the current behavior?
There was app crashing with extreme panning and zooming when using the InfiniteCanvas
What is the new behavior?
The framework API
CanvasComposition.CreateDrawingSessionthrows anArgumentExceptionif the drawing rectangle is too big (after zooming, and then attempting to pan/zoom again). There is no way to know what this limit is, and it may be system-specific. The only solution (in my opinion) that gives a reasonable user experience is to silently catch that particular exception during the ReDrraw method.PR Checklist
Please check if your PR fulfills the following requirements:
Other information