You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
[Package Size] Reduce size of new Controls.Primitives Package #3683
Evaluate removing the extra dependency to make the the Primitives package super light-weight in case no other elements of the Toolkit wish to be used by the end developer.
If we replaced FindParent we can drop Microsoft.Toolkit.Uwp and Microsoft.Toolkit.Uwp.UI but Microsoft.Toolkit would require replacing our usage of Guards and ThrowHelper.
@RosarioPulella looking at some of the initial impact reports Microsoft.Toolkit is definitely lighter than Microsoft.Toolkit.Uwp.UI for sure. I'm curious if we could get around the need for the FindParent usage in DockPanel somehow entirely (vs. copying that method).
Activity
michael-hawker commentedon Jan 22, 2021
@RosarioPulella forgot to ask if you noticed any other opportunities like this elsewhere in any of the refactors?
Rosuavio commentedon Jan 22, 2021
From
Microsoft.ToolkitPrimitivesuses
Guardstwicehttps://github.com/windows-toolkit/WindowsCommunityToolkit/blob/f55f101ca2be0772e02190c045b805d64501cf8a/Microsoft.Toolkit.Uwp.UI.Controls.Primitives/UniformGrid/TakenSpotsReferenceHolder.cs#L31
https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/f55f101ca2be0772e02190c045b805d64501cf8a/Microsoft.Toolkit.Uwp.UI.Controls.Primitives/UniformGrid/TakenSpotsReferenceHolder.cs#L32
And
ThrowHelperoncehttps://github.com/windows-toolkit/WindowsCommunityToolkit/blob/f55f101ca2be0772e02190c045b805d64501cf8a/Microsoft.Toolkit.Uwp.UI.Controls.Primitives/WrapPanel/WrapPanel.Data.cs#L66
If we replaced
FindParentwe can dropMicrosoft.Toolkit.UwpandMicrosoft.Toolkit.Uwp.UIbutMicrosoft.Toolkitwould require replacing our usage ofGuardsandThrowHelper.michael-hawker commentedon Jan 22, 2021
@RosarioPulella looking at some of the initial impact reports
Microsoft.Toolkitis definitely lighter thanMicrosoft.Toolkit.Uwp.UIfor sure. I'm curious if we could get around the need for theFindParentusage in DockPanel somehow entirely (vs. copying that method).Let me see how the rest of my investigation goes.
michael-hawker commentedon Feb 17, 2021
Think we're good here for now, just going to close this.