Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

[Follow-up] Remaining Items TODO for DesignTools Refactor #3620

Closed

Description

@michael-hawker

Describe the bug

There were a few small issues remaining with PR #3318. This issue is to track the remaining open small items to resolve before release.

TODO

@Nirmal4G you still up for helping us finalize these bits? Since the majority of everything else was looking good, we just wanted to get the main PR merged so we could continue our other refactors.

Activity

  1. added this to the 7.0 milestone on Dec 10, 2020
  2. Nirmal4G commented on Dec 12, 2020

    @Nirmal4G
    Contributor

    Sure. I'm okay with all the others except the TargetPlatform* properties.

    @azchohfi
    The reason I called the build number as Revision because it is the marker for the API "updates" or "revisions" in our case. It's a simpler term than what was used before.

  3. michael-hawker commented on Jan 6, 2021

    @michael-hawker
    MemberAuthor

    @Nirmal4G Think you can get to some of these before we close down for the release in the next couple of weeks?

    It'd at least be good to understand why the sperate Markdown package wasn't working as we're doing more work to split out the controls in #3660. Thanks!

  4. Nirmal4G commented on Jan 8, 2021

    @Nirmal4G
    Contributor

    Sure but before or after the mentioned PR?

    Also, do we need to separate the Design projects similar to the controls projects too?

  5. michael-hawker commented on Jan 12, 2021

    @michael-hawker
    MemberAuthor

    @Nirmal4G good point. We've broken ground on the PR, if you'd like to take a look at #3660 and see how the split out package looks, that'd be a great help, we'll do this for each of the sub-packages. I suppose it'll be easier to fix anything else afterwards once we've stabilized?

    Though the Markdown package won't be touched in the meantime, so investigating that bug can probably still be done in the meantime? You could also start a Wiki Page with the background info for the Design Tools and how they work in general too. Thanks!

  6. michael-hawker commented on Feb 25, 2021

    @michael-hawker
    MemberAuthor

    @Nirmal4G we've finished all the refactors to moving controls around, so if there's any polish or other clean-up you want to do in the next week before our final release, let us know. Thanks!

  7. Nirmal4G commented on Mar 6, 2021

    @Nirmal4G
    Contributor

    @michael-hawker I can't mark the TODOs in the issue description!

  8. michael-hawker commented on Mar 7, 2021

    @michael-hawker
    MemberAuthor

    @Nirmal4G sorry I guess it's because I filed the issue. Which ones would you like to mark off (or leave unmarked)?

  9. Kyaa-dost commented on Mar 11, 2021

    @Kyaa-dost
    Contributor

    Wiki page is not included in #3794 @Nirmal4G if you get a chance can you please include the Wiki page as well explaining DesignTools and its functionality in the Wiki repo Will get that merged too with the rest of the changes in the #3794

  10. modified the milestones: 7.0, 7.1 on Mar 16, 2021
  11. ghost closed this as completedin #4070on Aug 13, 2021
  12. ghost added a commit that references this issue on Aug 13, 2021
    2d74076
  13. ghost locked as resolved and limited conversation to collaborators on Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions