Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

[Feature] Ensure all controls have style names #3602

Closed

Description

@michael-hawker

Follow-on from microsoft/microsoft-ui-xaml#3735

Describe the problem this feature would solve

Over time in the toolkit we've been better at adopting better practices around making our styles. We should ensure that we go back and retroactively apply these to other older controls. 7.0 would be a good time to do this...

Describe the solution

Update Styles of controls to ensure that the base style is named and available. (though we may have another issue where these aren't getting exposed to the application level, see: #3556 (comment))

We also generally split out the ControlTemplate as well:

<Style TargetType="ControlName" BasedOn="DefaultControlNameStyle"/>

<Style x:Key="DefaultControlNameStyle" TargetType="ControlName">
    ...
    <Setter Property="Template" Value="{StaticResource DefaultControlTemplate}" />
</Style>

<ControlTemplate x:Key="DefaultControlTemplate" ...

Activity

  1. added this to the 7.0 milestone on Dec 4, 2020
  2. michael-hawker commented on Dec 4, 2020

    @michael-hawker
    MemberAuthor

    Realizing that our DefaultColorPickerStyle is going to conflict with the System/WinUI one... we may want to rename it? DefaultToolkitColorPickerStyle?

  3. modified the milestones: 7.0, 7.1 on Mar 1, 2021
  4. modified the milestones: 7.1, 7.2/8.0? on Aug 31, 2021
  5. ghost removed this from the 7.2/8.0? milestone on Aug 31, 2021
  6. added
    HacktoberfestHacktoberfest is a month-long celebration of open source software
    on Oct 7, 2021
  7. locked and limited conversation to collaborators on Jul 29, 2022
  8. converted this issue into a discussion #4684 on Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    HacktoberfestHacktoberfest is a month-long celebration of open source softwarefeature request 📬A request for new changes to improve functionalitygood first issueIssues identified as good for first-time contributorsimprovements ✨

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions