Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

[Feature] Update Designer Metadata to new VS2019 Model #3252

Closed

Description

@michael-hawker

Describe the problem this feature would solve

In VS 2019 they changed the model on how the designer loads metadata for components. See article here: https://github.com/microsoft/xaml-designer-extensibility/blob/master/documents/xaml-designer-extensibility-migration.md

The toolkit should update our designer metadata assemblies to align to this new pattern.

Activity

  1. michael-hawker commented on May 1, 2020

    @michael-hawker
    MemberAuthor

    Just realizing the new C# source generator features could help with this in the future, no?

  2. michael-hawker commented on May 15, 2020

    @michael-hawker
    MemberAuthor

    @Nirmal4G has volunteered to take a look at this initial investigation, thank you so much for taking a look, let us know what you find! 🦙❤

    Let us know if this looks straight-forward.

    (FYI, our code-complete for 6.1 is May 21st; however, I think this would constitute a breaking change, even though it's been long-overdue. So, we'd probably just delegate it to the 7.0 release later this summer when making any required changes can be done without problems.)

  3. added this to the 7.0 milestone on May 15, 2020
  4. removed their assignment
    on May 15, 2020
  5. Nirmal4G commented on May 16, 2020

    @Nirmal4G
    Contributor

    I'm working on it, but I don't know how l was unassigned. Somehow deleting the previous comment removed my assignment.

  6. michael-hawker commented on May 17, 2020

    @michael-hawker
    MemberAuthor

    @Nirmal4G no worries, GitHub is odd sometimes, I've placed it back to you. Thanks for taking a look!

  7. michael-hawker commented on May 28, 2020

    @michael-hawker
    MemberAuthor

    @Nirmal4G was just wondering if you had any luck in figuring this out or not yet? Thanks!

    FYI @azchohfi

  8. Nirmal4G commented on May 28, 2020

    @Nirmal4G
    Contributor

    Got it working last night. I didn't have the chance to clean it up yet. Tried Roslyn Generators but lack of documentation and a code writer forced me to modify the current source. Still have the implementation though. I'll create a draft PR this weekend for a review.

  9. michael-hawker commented on May 28, 2020

    @michael-hawker
    MemberAuthor

    That's great @Nirmal4G!!! That's going to be a huge help. We'll take a look at the PR once you have it together. I think it'll be a bit late for our upcoming 6.1 release, but we can look at the scope of changes and evaluate the PR, what's left, and timing then.

  10. ghost closed this as completedin #3318on Dec 10, 2020
  11. ghost added a commit that references this issue on Dec 10, 2020
    0975081
  12. ghost locked as resolved and limited conversation to collaborators on Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions