You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
New ListViewBase extensions - SmoothScrollIntoView #1499
Seems interesting to me :) maybe we can also include delay in scroll so the developer can control the scroll speed. let see what the community members think
Based on discussions on this topic I've had, you probably want to make the ScrollIfVisibile a Boolean to separate it from where to scroll the object to. e.g. you may want to scroll the item to the center, but only if it's not already visible.
@IbraheemOsama We should add 'Speed' (pixels per second) instead for 'Delay' or 'Duration'. So the duration of the animation will be (Math.Abs(previousOffset - newPosition)*1000)/speed. Also, we could have MaxDuration property to override calculated duration if it exceeds MaxDuration.
I am sorry guys. I can't create a PR for this because I don't think I have enough knowledge to do it. I have never created a helper or control other than for my own use.
@Vijay-Nirmal everyone had this moment of 'First PR' :) when I created a gitHub account I didn't have any previous PR :P
Submit a PR and we'll help and share the knowledge through reviewing the PR.
Thanks, but I don't think I have enough knowledge about UWP development. I am sorry I can't create a PR for this. But in the future, when I am well versed in UWP development, I will create a PR to create a different feature.
@Vijay-Nirmal can you summarize what items are you waiting on from me at the moment? It sounds like you worked around most of your sample app issues?
If you're pretty close to completeness, can you open a Draft PR with the changes? It'll make it easier to review and point-out any assistance with any open questions you have as well.
Not working properly when using ItemsStackPanel as ItemsPanel. See SmoothScrollingHelper#1 for more details. I don't think it is the problem of the virtualized panel because ItemsWrapGrid works properly.
Activity
IbraheemOsama commentedon Sep 18, 2017
Seems interesting to me :) maybe we can also include delay in scroll so the developer can control the scroll speed. let see what the community members think
michael-hawker commentedon Sep 18, 2017
Based on discussions on this topic I've had, you probably want to make the ScrollIfVisibile a Boolean to separate it from where to scroll the object to. e.g. you may want to scroll the item to the center, but only if it's not already visible.
Vijay-Nirmal commentedon Sep 19, 2017
@IbraheemOsama We should add 'Speed' (pixels per second) instead for 'Delay' or 'Duration'. So the duration of the animation will be
(Math.Abs(previousOffset - newPosition)*1000)/speed. Also, we could haveMaxDurationproperty to override calculated duration if it exceedsMaxDuration.@michael-hawker I like the idea and it would be easy to do.
I am sorry guys. I can't create a PR for this because I don't think I have enough knowledge to do it. I have never created a helper or control other than for my own use.
IbraheemOsama commentedon Sep 20, 2017
@Vijay-Nirmal everyone had this moment of 'First PR' :) when I created a gitHub account I didn't have any previous PR :P
Submit a PR and we'll help and share the knowledge through reviewing the PR.
nmetulev commentedon Sep 26, 2017
@Vijay-Nirmal, please let us know if you would be able to submit a PR for this. Most of us would be more than happy to help :)
Vijay-Nirmal commentedon Sep 27, 2017
Thanks, but I don't think I have enough knowledge about UWP development. I am sorry I can't create a PR for this. But in the future, when I am well versed in UWP development, I will create a PR to create a different feature.
thecodrr commentedon Oct 7, 2017
@nmetulev I can take a look at this as soon as possible, if you want? This will be an exciting adventure.
nmetulev commentedon Oct 7, 2017
Feel free to take this one @theweavrs
nmetulev commentedon Oct 24, 2017
@theweavrs, were you planing on implementing this one? If so, I'll set the milestone for 2.1
Vijay-Nirmal commentedon Jan 4, 2018
@nmetulev I will do it.
When I build the solution it gives me errors and warnings. I didn't change any code.
Here is the full error list
Error List pdf
nmetulev commentedon Jan 4, 2018
That's great @Vijay-Nirmal.
This is a known issue with the new design project. We believe it's a VS/NuGet bug and those errors can be safely ignored.
40 remaining items
Vijay-Nirmal commentedon Mar 11, 2020
@michael-hawker Update?
michael-hawker commentedon Apr 4, 2020
@Vijay-Nirmal can you summarize what items are you waiting on from me at the moment? It sounds like you worked around most of your sample app issues?
If you're pretty close to completeness, can you open a Draft PR with the changes? It'll make it easier to review and point-out any assistance with any open questions you have as well.
Thanks!
Vijay-Nirmal commentedon Apr 5, 2020
@michael-hawker I have created Draft PR #3222. I have two questions
TextBlockto create the properties in Properties Panel. Is it ok to do it?https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/9ad0b20029c9266d0f3d162520fe549a9a9243fe/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/ListViewExtensions/ListViewExtensionsXaml.bind#L20-L21
https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/9ad0b20029c9266d0f3d162520fe549a9a9243fe/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/ListViewExtensions/ListViewExtensionsPage.xaml.cs#L32-L33
ItemsWrapGridworks properly.