You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Incorrect Labs control's link on WCT Gallery app #587
The sample app just assumes everything is from one repository, so we don't have configuration per component to tell it otherwise at the moment. So, that's why they point to the wrong place, as we decided later to add in the labs components for discoverability, as people would be asking about them all the time... but the sample app needs a bit more work still.
We don't really have a great hook at the moment to do a lot of extra custom logic to determine the source of a component (as we build the sample app by just dumping the components from one repo in another vs. having a system that knows about both repos).
And we haven't really wanted to explicitly have to define this for every sample/doc.
Ultimately, as part of the ability for the sample to be skinnable and re-useable for hosting any components and for other projects like the AI Dev Gallery and the WinUI Gallery, we need to have some sort of plugin structure which can provide assets as well as code, which then can get all the source/metadata about the components and transform/provide the proper behavior for these types of scenarios.
publicstaticUri?ToComponentUri(stringname,bool?isExperimental=null){if(IsProjectPathValid()is not true){returnnull;}string?url=(isExperimentalisnull||isExperimentalisfalse)?ProjectUrl:ProjectUrl?.Replace("Windows","Labs-Windows");returnnewUri($"{url}/tree/main/components/{name}");}
@Arlodotexe looks like we have some sort of inconsistencies in the project names and the package names. Like the Labs packages have .Labs. in them, but not all the project files do... this trips up some of how the sample app looks at the metadata to create links.
I think this is tied to a simplification we tried to do a while back for the namespaces, but we still wanted the packages to have Labs or something. And now we're just inconsistent, so I may need to think about how to fix this for the package links.
Activity
michael-hawker commentedon Dec 21, 2024
Related to CommunityToolkit/Tooling-Windows-Submodule#19
This isn't that simple of an issue unfortunately.
The sample app just assumes everything is from one repository, so we don't have configuration per component to tell it otherwise at the moment. So, that's why they point to the wrong place, as we decided later to add in the labs components for discoverability, as people would be asking about them all the time... but the sample app needs a bit more work still.
https://github.com/search?q=repo%3ACommunityToolkit%2FTooling-Windows-Submodule%20ToComponentUri&type=code
Grabbing from the assembly attribute defined by the hosting repo:
https://github.com/CommunityToolkit/Tooling-Windows-Submodule/blob/83dff9fab1be976d2ae4d401f15af9c6b889caeb/CommunityToolkit.App.Shared/Renderers/ToolkitDocumentationRenderer.xaml.cs#L35-L38
We don't really have a great hook at the moment to do a lot of extra custom logic to determine the source of a component (as we build the sample app by just dumping the components from one repo in another vs. having a system that knows about both repos).
And we haven't really wanted to explicitly have to define this for every sample/doc.
Ultimately, as part of the ability for the sample to be skinnable and re-useable for hosting any components and for other projects like the AI Dev Gallery and the WinUI Gallery, we need to have some sort of plugin structure which can provide assets as well as code, which then can get all the source/metadata about the components and transform/provide the proper behavior for these types of scenarios.
AndrewKeepCoding commentedon Dec 23, 2024
Since each component card from Labs shows a [Labs] yellow tag, I thought we could use it to create the correct URL.
For instance, replacing:
ToolkitDocumentationRenderer.xaml.cs
with:
then use it:
ToolkitDocumentationRenderer.xaml
michael-hawker commentedon Mar 19, 2025
Have a test for this locally. Also needed to update
ToPackageUriwith a similar pattern to point to the Labs nuget feed root: https://dev.azure.com/dotnet/CommunityToolkit/_artifacts/feed/CommunityToolkit-Labs/NuGet/michael-hawker commentedon Mar 19, 2025
@Arlodotexe looks like we have some sort of inconsistencies in the project names and the package names. Like the Labs packages have
.Labs.in them, but not all the project files do... this trips up some of how the sample app looks at the metadata to create links.I think this is tied to a simplification we tried to do a while back for the namespaces, but we still wanted the packages to have Labs or something. And now we're just inconsistent, so I may need to think about how to fix this for the package links.
michael-hawker commentedon Mar 20, 2025
Ribbon and TitleBar (and maybe others are also mismatched with whether or not they have
.Controls.between project name and package.If we figure out what things should be, we can ensure the sample app is built that way, and then update them in the feed before it goes live.
Initial take on fixing sample app source/package links for Labs exper…
Initial take on fixing sample app source/package links for Labs exper…
Arlodotexe commentedon Apr 3, 2025
Closed by CommunityToolkit/Tooling-Windows-Submodule#275