Repository navigation
Closed
Labels
accessibility
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededux 🖌️Everything design relatedEverything design related
Description
Describe the bug
Issue
Accessibility Insights reporting: "A button must support one of these patterns: Invoke, Toggle, or ExpandCollapse." when using a SettingsCard that is clickable (IsClickEnabled=True).
Investigation
SettingsCardAutomationPeermay possibly need to implementGetPatternCore(PatternInterface patternInterface)method.
protected override object GetPatternCore(PatternInterface patternInterface)
{
return patternInterface == PatternInterface.Invoke ? this : base.GetPatternCore(patternInterface);
}- Implement
IInvokeProviderin the same class (since we're returningthis). - Or instead, maybe the
SettingsCardAutomationPeercan inherit fromButtonBaseAutomationPeer?
Steps to reproduce
- Add a settings card
<controls:SettingsCard Header="Example" IsClickEnabled="True" />
- Run accessibility scan on the displayed card
- The following error is reported: "A button must support one of these patterns: Invoke, Toggle, or ExpandCollapse."
Expected behavior
No errors
Screenshots
No response
Code Platform
- UWP
- WinAppSDK / WinUI 3
- Web Assembly (WASM)
- Android
- iOS
- MacOS
- Linux / GTK
Windows Build Number
- Windows 10 1809 (Build 17763)
- Windows 10 1903 (Build 18362)
- Windows 10 1909 (Build 18363)
- Windows 10 2004 (Build 19041)
- Windows 10 20H2 (Build 19042)
- Windows 10 21H1 (Build 19043)
- Windows 10 21H2 (Build 19044)
- Windows 10 22H2 (Build 19045)
- Windows 11 21H2 (Build 22000)
- Other (specify)
Other Windows Build number
No response
App minimum and target SDK version
- Windows 10, version 1809 (Build 17763)
- Windows 10, version 1903 (Build 18362)
- Windows 10, version 1909 (Build 18363)
- Windows 10, version 2004 (Build 19041)
- Windows 10, version 2104 (Build 20348)
- Windows 11, version 22H2 (Build 22000)
- Other (specify)
Other SDK version
No response
Visual Studio Version
No response
Visual Studio Build Number
No response
Device form factor
No response
Additional context
No response
Help us help you
Yes, I'd like to be assigned to work on this item.
Metadata
Metadata
Assignees
Labels
accessibility
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededux 🖌️Everything design relatedEverything design related
Type
Projects
- StatusShow more project fields✅ Done
Activity
michael-hawker commentedon Apr 4, 2024
Thanks @AmelBawa-msft for the report and offering to help. We're working towards an 8.1 release in the near future. This seems like a simple fix, if you can open a PR this week, we can get look to get it into the upcoming release. FYI @niels9001
niels9001 commentedon Dec 2, 2024
@AmelBawa-msft Just wanted to check; were you planning to do a PR with these fixes?
AmelBawa-msft commentedon Dec 2, 2024
@niels9001, unfortunately I will not be working on this PR. At least not in the near future. If anyone would like to load balance, please feel free to do so ❤️
g0g8rz commentedon Jun 3, 2025
Just to add some more support for this issue, it seems this might be a blocker for software trying to comply with the European accessibility act (wikipedia summary) which takes full effect June 2025. From my understanding (although I am not a lawyer, nor a European) software must comply with Web Content Accessibility Guidelines (WCAG) and UIs containing the SettingsCard fails WCAG 4.1.2
Fixed a11y issue CommunityToolkit#391
Fixed a11y issue #391