Skip to content

SettingsCard missing invoke pattern #391

Closed

Description

@AmelBawa-msft

Describe the bug

Issue

Accessibility Insights reporting: "A button must support one of these patterns: Invoke, Toggle, or ExpandCollapse." when using a SettingsCard that is clickable (IsClickEnabled=True).

Investigation

  • SettingsCardAutomationPeer may possibly need to implement GetPatternCore(PatternInterface patternInterface) method.
protected override object GetPatternCore(PatternInterface patternInterface)
{
    return patternInterface == PatternInterface.Invoke ? this : base.GetPatternCore(patternInterface);
}
  • Implement IInvokeProvider in the same class (since we're returning this).
  • Or instead, maybe the SettingsCardAutomationPeer can inherit from ButtonBaseAutomationPeer?

Steps to reproduce

- Add a settings card

<controls:SettingsCard Header="Example" IsClickEnabled="True" />


- Run accessibility scan on the displayed card
- The following error is reported: "A button must support one of these patterns: Invoke, Toggle, or ExpandCollapse."

Expected behavior

No errors

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 10 21H2 (Build 19044)
  • Windows 10 22H2 (Build 19045)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Windows 10, version 2104 (Build 20348)
  • Windows 11, version 22H2 (Build 22000)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

Activity

  1. michael-hawker commented on Apr 4, 2024

    @michael-hawker
    Member

    Thanks @AmelBawa-msft for the report and offering to help. We're working towards an 8.1 release in the near future. This seems like a simple fix, if you can open a PR this week, we can get look to get it into the upcoming release. FYI @niels9001

  2. moved this to 🏗 In progress in Toolkit 8.xon Apr 4, 2024
  3. moved this from 🏗 In progress to 📋 Backlog in Toolkit 8.xon Jul 11, 2024
  4. moved this from 📋 Backlog to 🔖 Ready in Toolkit 8.xon Oct 21, 2024
  5. niels9001 commented on Dec 2, 2024

    @niels9001
    Collaborator

    @AmelBawa-msft Just wanted to check; were you planning to do a PR with these fixes?

  6. AmelBawa-msft commented on Dec 2, 2024

    @AmelBawa-msft
    Author

    @niels9001, unfortunately I will not be working on this PR. At least not in the near future. If anyone would like to load balance, please feel free to do so ❤️

  7. g0g8rz commented on Jun 3, 2025

    @g0g8rz

    Just to add some more support for this issue, it seems this might be a blocker for software trying to comply with the European accessibility act (wikipedia summary) which takes full effect June 2025. From my understanding (although I am not a lawyer, nor a European) software must comply with Web Content Accessibility Guidelines (WCAG) and UIs containing the SettingsCard fails WCAG 4.1.2

    Image

  8. moved this from 🔖 Ready to 👀 In review in Toolkit 8.xon Jul 15, 2025
  9. added a commit that references this issue on Jul 17, 2025
  10. moved this from 👀 In review to ✅ Done in Toolkit 8.xon Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions