Skip to content

Improve Samples in Media #124

Description

@Arlodotexe
No description provided.

Activity

  1. changed the title [-]Improve Samples[/-] [+]Improve Samples in Media[/+] on Jul 11, 2023
  2. self-assigned this
    on Jul 11, 2023
  3. moved this from 🆕 New to 🔖 Ready in Toolkit 8.xon Jul 11, 2023
  4. moved this from 🔖 Ready to 🏗 In progress in Toolkit 8.xon Jul 13, 2023
  5. moved this from 🏗 In progress to 👀 In review in Toolkit 8.xon Jul 18, 2023
  6. moved this from 👀 In review to ✅ Done in Toolkit 8.xon Aug 21, 2023
  7. Arlodotexe commented on May 21, 2024

    @Arlodotexe
    MemberAuthor

    In #151, we ported all existing samples for the Media package from the 7.x sample app. This included samples for Shadows and EffectAnimations, but not for Brushes, Effects, or Pipelines.

    We have users asking for samples on how to use things like TilesBrush, and so we should add them to the gallery. Additionally, for components without tests, this gives us a simple way to ensure these tools work as expected.

    I've reopened this issue so we can add samples for the following:

    • Brushes
    • Effects
    • Pipelines
  8. moved this from ✅ Done to 🔖 Ready in Toolkit 8.xon May 21, 2024
  9. moved this from 🔖 Ready to 📋 Backlog in Toolkit 8.xon May 21, 2024
  10. added this to the 8.2 milestone on Dec 18, 2024
  11. michael-hawker commented on Dec 18, 2024

    @michael-hawker
    Member

    FYI @TheJoeFin posted to ask about TilesBrush on BlueSky here - seems like it may be broken?

    @Arlodotexe since we're probably not shipping 8.2 now until the new year, this could be a thing to spend a day and prop up again on our radar for any clean-up leading into it?

  12. 8 remaining items

  13. erinpwoo commented on Feb 20, 2025

    @erinpwoo
    Contributor

    Almost done making the last set of changes for adding brush and pipeline samples. Will publish PR by EOD 2/21 @michael-hawker

  14. DaveAurionix commented on Feb 21, 2025

    @DaveAurionix

    @erinpwoo if you have a sample for the TilesBrush coming as part of the brush samples you mention, that would be awesome. I'm asking because in the latest stable package (8.1.240916) the TilesBrush appears to be broken (seems not to render anything). Same in latest preview package 8.2.250129-preview2. That's on WinUI 3. The sample would provide evidence that it basically works and would help me spot what I'm doing differently and raise a targeted issue and repro steps if needed.

  15. erinpwoo commented on Feb 21, 2025

    @erinpwoo
    Contributor

    @DaveAurionix yes, a TilesBrush sample is included. Link to PR: #639

  16. erinpwoo commented on Feb 21, 2025

    @erinpwoo
    Contributor

    @DaveAurionix yes, a TilesBrush sample is included. Link to PR: #639

    Also, just validated the version this was built with is 8.2.1

  17. michael-hawker commented on Feb 22, 2025

    @michael-hawker
    Member

    @erinpwoo have you switched to check WinUI 3 or just been running against UWP while developing?

  18. moved this from 🏗 In progress to 👀 In review in Toolkit 8.xon Feb 24, 2025
  19. Arlodotexe commented on Mar 26, 2025

    @Arlodotexe
    MemberAuthor

    In #151, we ported all existing samples for the Media package from the 7.x sample app. This included samples for Shadows and EffectAnimations, but not for Brushes, Effects, or Pipelines.

    We have users asking for samples on how to use things like TilesBrush, and so we should add them to the gallery. Additionally, for components without tests, this gives us a simple way to ensure these tools work as expected.

    I've reopened this issue so we can add samples for the following:

    • Brushes
    • Effects
    • Pipelines

    Samples for Pipelines and Brushes were added in #654, meaning only Effects samples are left to add.

  20. moved this from 👀 In review to 🔖 Ready in Toolkit 8.xon Apr 3, 2025
  21. linked a pull request that will close this issueErinwoo/media samples #654on May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions