Repository navigation
Closed
Labels
Description
Describe the bug
Related to #77
If you right-click on a library and try and Pack to build a NuGet package you get an error about Icon.png missing.
In face these resources for the icon don't exist in the repro:
We should be able to pack locally as well as have the proper files and icons included in the NuGet package.
@niels9001 do you know which icon asset should we use?
Steps to reproduce
1) Open an experiment or the all solution
2) Find a Library project
3) right-click on it and select 'Pack'
4) see error
Expected behavior
Able to pack NuGet package
Screenshots
No response
Code Platform
- UWP
- WinAppSDK / WinUI 3
- Web Assembly (WASM)
- Android
- iOS
- MacOS
- Linux / GTK
Windows Build Number
- Windows 10 1809 (Build 17763)
- Windows 10 1903 (Build 18362)
- Windows 10 1909 (Build 18363)
- Windows 10 2004 (Build 19041)
- Windows 10 20H2 (Build 19042)
- Windows 10 21H1 (Build 19043)
- Windows 11 21H2 (Build 22000)
- Other (specify)
Other Windows Build number
No response
App minimum and target SDK version
- Windows 10, version 1809 (Build 17763)
- Windows 10, version 1903 (Build 18362)
- Windows 10, version 1909 (Build 18363)
- Windows 10, version 2004 (Build 19041)
- Other (specify)
Other SDK version
No response
Visual Studio Version
No response
Visual Studio Build Number
No response
Device form factor
No response
Additional context
I guess this is ignored on the commandline?
Help us help you
Yes, but only if others can assist.
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
- StatusShow more project fields✅ Done
Activity
michael-hawker commentedon Dec 13, 2022
Note: If you comment out the Icon.png line 12 of the Windows.Toolkit.Common.props, then you can pack locally.
Nirmal4G commentedon Jan 13, 2023
Just stumbled across this when going through repo...
<PackageIconUrl>as it's no longer needed. It is replaced by<PackageIcon>.Icon.pngin theRepositoryDirectoryor$(BuildToolsDirectory).That should fix the issue. Ping me if any build code that was updated by me causing any problems. You can check
git blameto see who wrote what line.michael-hawker commentedon Jan 13, 2023
Thanks for the tips @Nirmal4G. I remember we were trying to use
PackageIconUrlstill for some reason, but I don't remember what that reason was now... Maybe it was some prior VS issue that maybe's now resolved.@niels9001 where else were we talking about the icon? I see we have #77 as well, but I don't see our prior chat there.
Let's get the new icon setup next week during a 1:1 and then we can get a PR opened to close this and that issue together.
niels9001 commentedon Jan 20, 2023
For reference, NuGet icon for Labs can be found here: https://github.com/CommunityToolkit/design-assets/blob/main/Logos/Windows-Labs/Windows-Labs.nuget-256.png
michael-hawker commentedon Aug 1, 2023
https://dev.azure.com/dotnet/CommunityToolkit/_artifacts/feed/CommunityToolkit-MainLatest/NuGet/CommunityToolkit.Uwp.Extensions/overview/8.0.230801-preview
Huh, I updated the
PackageIconproperty and fixed this in 162, but then I don't see it showing up properly in NuGet Explorer...Same in VS:
Looks like it's missing even though it's clearly defined here: https://github.com/CommunityToolkit/Windows/blob/710c30ff564fe596b03db7ab247d267c7fd8a171/Windows.Toolkit.Common.props#L12
I'm not sure why this didn't work...
Nirmal4G commentedon Aug 4, 2023
@michael-hawker I don't see an
<icon/>element in the package manifest xml file you mentioned above. There's a possibility that<PackageIcon/>value either clears out before it enters the NuGet pack logic or does not pass through at all. Check it with MSBuild Log Viewer.michael-hawker commentedon Aug 15, 2023
Thanks for pointing that out @Nirmal4G, I'll have to look. We'll also have to be aware of this issue as well: NuGet/Home#9250 - but I'd imagine the Package Explorer app wouldn't have that same issue.
michael-hawker commentedon Aug 16, 2023
Going to try updating the NuGet pack lib we were using 5.2.0, but there's a 6.7.0 available - iconUrl is working fine... just not
PackageIcon...michael-hawker commentedon Aug 16, 2023
Confirmed this is fixed by CommunityToolkit/Windows#174 now! 🎉🎉🎉
According to this doc still it's recommended to specify both so that older clients can get the icon from the url. So, I'll leave that in.
Was definitely due to us using version 5.2.0... 🤦♂️ Filed an issue as that is the version called out in the docs as well: https://github.com/NuGet/docs.microsoft.com-nuget/issues/3124