Skip to content

[Feature] Separate Graph SDK interaction into own package #75

Closed

Description

@shweaver-MSFT

Describe the problem this feature would solve

I don't want the bloat of the entire Graph SDK if I only need to do authentication.

Describe the solution

The Graph SDK isn't really needed for authentication. There is a smaller Graph.Auth package we can use to get the core constructs to enable the sign in flow to work. The rest of the Graph SDK consumption should be relegated to a separate package, Microsoft.Toolkit.Graph.Data (or something similar), upon which the other packages can depend on as needed.

Microsoft.Toolkit.Graph.Data

This package will manage how we leverage the Graph SDK and interact with the Graph APIs.

In addition, the Graph SDK occasionally has bugs. A layer of indirection will allow us to workaround any issues while maintaining a consistent usage pattern across the solution.

Describe alternatives you've considered

Additional context & Screenshots

Activity

  1. changed the title [-][Feature] Separate Graph SDK interaction into Data package[/-] [+][Feature] Separate Graph SDK interaction into own package[/+] on Mar 15, 2021
  2. shweaver-MSFT commented on Mar 25, 2021

    @shweaver-MSFT
    MemberAuthor

    This was changed in PR #76.

    Now the main CommunityToolkit.Net.Authentication package no longer relies on the Graph SDK. All Graph SDK interaction is relegated to the CommunityToolkit.Net.Graph package

  3. ghost locked as resolved and limited conversation to collaborators on Apr 24, 2021
  4. added this to the 7.1.0 milestone on Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions